Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken retries in ansible tasks #444

Closed
robrap opened this issue Sep 8, 2023 · 1 comment
Closed

Fix broken retries in ansible tasks #444

robrap opened this issue Sep 8, 2023 · 1 comment
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented Sep 8, 2023

A/C:

  • All existing Ansible retries in the configuration repo use the correct syntax

Here is an example of task with retries that was broken, and PR with fix:

TASK [Tag EC2 instance] ********************************************************
...
fatal: [localhost]: FAILED! => {
    ...
    "response_metadata": {
        ...
        "retry_attempts": 0
    }
}

We might need some eSRE education around this issue.

Here are a list of other broken retries that probably need to be fixed:

$ pip install yq
$ find -name '*.yml' | while read -r path; do output=$(< $path yq '.. | select(.retries? != null and (.register == null or .until == null))'); if [[ -n "$output" ]]; then echo "$path"; fi done
./playbooks/continuous_delivery/launch_instance.yml
./playbooks/roles/mongo_3_6/tasks/main.yml
./playbooks/roles/mongo_2_6/tasks/main.yml
./playbooks/roles/mongo_4_2/tasks/main.yml
./playbooks/roles/redis/tasks/main.yml
./playbooks/roles/ad_hoc_reporting/tasks/main.yml
./playbooks/roles/mongo_4_4/tasks/main.yml
./playbooks/roles/mongo_3_2/tasks/main.yml
./playbooks/roles/mongo_4_0/tasks/main.yml
./playbooks/roles/mongo_3_4/tasks/main.yml
./playbooks/roles/mongo_client/tasks/main.yml
./playbooks/roles/python/tasks/main.yml
@robrap robrap added this to Arch-BOM Sep 8, 2023
@robrap robrap converted this from a draft issue Sep 8, 2023
@robrap robrap added the esre label Sep 8, 2023
@jmbowman jmbowman moved this to Prioritized in Arch-BOM Sep 13, 2023
@jmbowman jmbowman removed the esre label Sep 13, 2023
@jmbowman jmbowman moved this from Prioritized to On-Call in Arch-BOM Sep 13, 2023
@rgraber rgraber self-assigned this Oct 19, 2023
@rgraber rgraber moved this from On-Call to In Progress in Arch-BOM Oct 19, 2023
@rgraber
Copy link
Contributor

rgraber commented Oct 19, 2023

Fixed with openedx-unsupported/configuration#7049

@rgraber rgraber closed this as completed Oct 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Arch-BOM Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants