-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix make test-all
by implementing pii_check
#527
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# This is a Code Annotations automatically-generated Django model safelist file. | ||
# These models must be annotated as follows in order to be counted in the coverage report. | ||
# See https://code-annotations.readthedocs.io/en/latest/safelist.html for more information. | ||
# | ||
# fake_app_1.FakeModelName: | ||
# ".. no_pii:": "This model has no PII" | ||
# fake_app_2.FakeModel2: | ||
# ".. choice_annotation:": foo, bar, baz | ||
|
||
admin.LogEntry: | ||
".. no_pii:": "This model has no PII" | ||
auth.Group: | ||
".. no_pii:": "This model has no PII" | ||
auth.Permission: | ||
".. no_pii:": "This model has no PII" | ||
auth.User: | ||
".. pii": "This model minimally contains a username, password, and email" | ||
".. pii_types": "username, email_address, password" | ||
".. pii_retirement": "consumer_api" | ||
contenttypes.ContentType: | ||
".. no_pii:": "This model has no PII" | ||
sessions.Session: | ||
".. no_pii:": "This model has no PII" | ||
social_django.Association: | ||
".. no_pii:": "This model has no PII" | ||
social_django.Code: | ||
".. pii:": "Email address" | ||
".. pii_types:": other | ||
".. pii_retirement:": local_api | ||
social_django.Nonce: | ||
".. no_pii:": "This model has no PII" | ||
social_django.Partial: | ||
".. no_pii:": "This model has no PII" | ||
social_django.UserSocialAuth: | ||
".. no_pii:": "This model has no PII" | ||
waffle.Flag: | ||
".. no_pii:": "This model has no PII" | ||
waffle.Sample: | ||
".. no_pii:": "This model has no PII" | ||
waffle.Switch: | ||
".. no_pii:": "This model has no PII" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ build/ | |
**/private.py | ||
.coverage | ||
dist/ | ||
/pii_report/*.yaml | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
source_path: ./ | ||
report_path: pii_report | ||
safelist_path: .annotation_safe_list.yml | ||
coverage_target: 100.0 | ||
annotations: | ||
".. no_pii:": | ||
"pii_group": | ||
- ".. pii:": | ||
- ".. pii_types:": | ||
choices: | ||
- id # Unique identifier for the user which is shared across systems | ||
- name # Used for any part of the user's name | ||
- username | ||
- password | ||
- location # Used for any part of any type address or country stored | ||
- phone_number # Used for phone or fax numbers | ||
- email_address | ||
- birth_date # Used for any part of a stored birth date | ||
- ip # IP address | ||
- external_service # Used for external service ids or links such as social media links or usernames, website links, etc. | ||
- biography # Any type of free-form biography field | ||
- gender | ||
- sex | ||
- image | ||
- video | ||
- other | ||
- ".. pii_retirement:": | ||
choices: | ||
- retained # Intentionally kept for legal reasons | ||
- local_api # An API exists in this repository for retiring this information | ||
- consumer_api # The data's consumer must implement an API for retiring this information | ||
- third_party # A third party API exists to retire this data | ||
extensions: | ||
python: | ||
- py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly enough, this isn't in any .gitignore files in edx and openedx repos. Maybe pii_check isn't hooked into test-all in other repos, or people don't use it, or they use
make clean
before going to commit.