Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator enhancment #21

Open
Nopzen opened this issue Mar 8, 2018 · 0 comments
Open

Validator enhancment #21

Nopzen opened this issue Mar 8, 2018 · 0 comments
Assignees

Comments

@Nopzen
Copy link
Collaborator

Nopzen commented Mar 8, 2018

Upon reviewing the #20 pull request, i stumpled upon the validator function and i was raising a flag that this can be done better with a proper if else if statement not returning false have the time, but instead throwing proper errors.

Im just raising this issue as a reminder for my self to get back to a re-write of this at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant