Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak header and pager in print view #241

Merged
merged 5 commits into from
Jun 14, 2019
Merged

fix: tweak header and pager in print view #241

merged 5 commits into from
Jun 14, 2019

Conversation

alexjohndoe
Copy link
Contributor

@alexjohndoe alexjohndoe commented Jun 12, 2019

Fixes #227

@egoist
Copy link
Owner

egoist commented Jun 13, 2019

屏幕快照 2019-06-13 下午10 51 19

the first page has a weird top padding.

@alexjohndoe
Copy link
Contributor Author

I removed the weird top padding by reducing the padding-top of .Main by --header-height.

@egoist
Copy link
Owner

egoist commented Jun 13, 2019

hmm I think there should be no padding at all?

@alexjohndoe
Copy link
Contributor Author

Yes, using padding-top: 0 is better:

I will fix this.

@alexjohndoe
Copy link
Contributor Author

Done. The top padding is now completely removed.

@egoist
Copy link
Owner

egoist commented Jun 13, 2019

welp maybe we can just unset position: fixed for header, it's weird if we don't show header at all 😅

@alexjohndoe
Copy link
Contributor Author

Good solution. 👍

@alexjohndoe
Copy link
Contributor Author

A little more discussion: should .header-nav hide or not?

@egoist
Copy link
Owner

egoist commented Jun 13, 2019

it's fine to keep it I guess, as long as it doesn't break anything.

@alexjohndoe
Copy link
Contributor Author

I think .header-nav can be removed, because the header nav holds commonly used tools, e.g. search bar, help buttons, notice buttons, etc.

But I also agree with your thoughts.

I will keep it.

@egoist
Copy link
Owner

egoist commented Jun 13, 2019

we do have a search bar, it should be hidden then

@egoist
Copy link
Owner

egoist commented Jun 13, 2019

btw, do you actually print the PDF in papers or just need the PDF file? header nav will still be useful when you're viewing the PDF file.

@alexjohndoe
Copy link
Contributor Author

Both. When making PDFs, it looks nice. But when printing in papers, it used too much papers, because the margins and the line height are too large. It can be optimized, but my design sense is poor.

@alexjohndoe
Copy link
Contributor Author

Another non-topic discussion: when using projector, the text is too small to be seen. I often use command + + to increase the text size. 🤣

@egoist egoist changed the title Hide header and pager in print view fix: tweak header and pager in print view Jun 14, 2019
@egoist egoist merged commit 71fc2b0 into egoist:master Jun 14, 2019
@egoist
Copy link
Owner

egoist commented Jun 14, 2019

🎉 This PR is included in version 4.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header is overlapping with contents in print view
2 participants