-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tweak header and pager in print view #241
Conversation
I removed the weird top padding by reducing the |
hmm I think there should be no padding at all? |
Done. The top padding is now completely removed. |
welp maybe we can just unset |
Good solution. 👍 |
A little more discussion: should |
it's fine to keep it I guess, as long as it doesn't break anything. |
I think But I also agree with your thoughts. I will keep it. |
we do have a search bar, it should be hidden then |
btw, do you actually print the PDF in papers or just need the PDF file? header nav will still be useful when you're viewing the PDF file. |
Both. When making PDFs, it looks nice. But when printing in papers, it used too much papers, because the margins and the line height are too large. It can be optimized, but my design sense is poor. |
Another non-topic discussion: when using projector, the text is too small to be seen. I often use |
🎉 This PR is included in version 4.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #227