Skip to content
This repository has been archived by the owner on Dec 6, 2021. It is now read-only.

Webpack hot reload not working #217

Closed
layanto opened this issue Jul 31, 2017 · 6 comments
Closed

Webpack hot reload not working #217

layanto opened this issue Jul 31, 2017 · 6 comments

Comments

@layanto
Copy link

layanto commented Jul 31, 2017

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
When making Vue template change, page refreshed instead of webpack hot reload.
If the current behavior is a bug, please provide the steps to reproduce.
Was working fine with power 9.1.2. Tested not working on point 9.1.7 and 9.1.8.

What is the expected behavior?
Page reload via webpack hot reload.
If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information such as the browser version, Node.js version, Poi version and Operating System.
Node 6.11.1
Poi 9.1.8
Is Win 10

@layanto
Copy link
Author

layanto commented Jul 31, 2017

Auto correct!!
Was working fine with poi 9.1.2. Tested not working on poi 9.1.7 and 9.1.8.

@egoist
Copy link
Owner

egoist commented Jul 31, 2017

Hmm tried poi 9.1.8 and HMR works fine with template, tested with this template: https://github.com/egoist/template-poi-minimal

@layanto
Copy link
Author

layanto commented Jul 31, 2017

With my project, poi 9.1.2 works fine but poi 9.1.3 HMR not working properly. How to find out what was changed between poi 9.1.2 and 9.1.3?

@layanto
Copy link
Author

layanto commented Jul 31, 2017

Seems to do with this commit: 459749f

If I add the ModuleConcatenationPlugin in the above commit to poi 9.1.2, HMR stops working for me.

@egoist
Copy link
Owner

egoist commented Aug 1, 2017

ok seems ModuleConcatenationPlugin is still experimental, I just removed it in latest version.

@egoist egoist closed this as completed Aug 1, 2017
@layanto
Copy link
Author

layanto commented Aug 1, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants