Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[track_caller] in all assertion functions #288

Closed
oblique opened this issue Jun 6, 2024 · 2 comments
Closed

Add #[track_caller] in all assertion functions #288

oblique opened this issue Jun 6, 2024 · 2 comments

Comments

@oblique
Copy link
Member

oblique commented Jun 6, 2024

No description provided.

@oblique oblique mentioned this issue Jun 19, 2024
Merged
@zvolin
Copy link
Member

zvolin commented Oct 4, 2024

is this still relevant?

@zvolin zvolin moved this to Todo in Lumina Oct 4, 2024
@zvolin zvolin added this to Lumina Oct 4, 2024
@oblique
Copy link
Member Author

oblique commented Oct 4, 2024

#[track_caller] does not support async fn yet (rust-lang/rust#110011) so some assertion functions in tests can not use it. Since what is left it is only related to test cases, we can close it.

@zvolin zvolin closed this as completed Oct 7, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Lumina Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Lumina
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oblique @zvolin