Constraint editor

[ekuiter]

Cross-tree constraints are often used in feature models. They should get a dedicated editing area, maybe with different layouts too (simplest is a list of propositional formulas, but maybe add filters or a visualization of formulas).

Constraints have many interactions with the feature model editor (like, the constraints need to be updated when a feature is renamed or removed).

[ekuiter]

For starters, we could use a simple text editor listing constraints (as in DarwinSPL). This can then be extended into a (kind of) graphical editor.

[ekuiter]

Simple constraint view is implemented. Apart from the missing editing commands (add, edit, remove), some TODOs include:

• can not scroll vertically when the list overflows in Firefox on Windows
• the scroll bars are ugly on Windows
• on Firefox/Windows, the width of constraints is not readjusted when the window width changes
• the drawer/handle is not touch-friendly (only works with mouse, add touch events)
• double clicking to change the split direction does not work on Firefox/Windows
• when rotating the device, auto-adjust the split direction

In the long run, a proper constraint editor should be implemented (cf. FeatureIDE). For now, we may simply input constraints more or less in the internal representation.
That is: To add a constraint, open the command palette, choose "add constraint", enter a constraint in prefix notation with parentheses, e.g. (imp A (disj B C)) (possibly allowing symbols such as -> and |). While typing, use the command palette API to display the parsed and rendered constraint (if it is well-formed), e.g. A -> B v C so that the user gets an idea what the constraint will be parsed as (maybe even display hints for the syntax, which symbols may be used etc.).
This prefix notation can then be easily parsed as JSON by string-replacing symbols and parentheses and passed into the kernel.

[ekuiter]

• Regarding "the width is not readjusted": I have no idea what causes this, IDetailsList's forceUpdate (or rerender with new items) does not help. Not a very pressing issue for now, though.
• Regarding "auto-adjust split direction": This interacts with the manual split direction change.

[ekuiter]

Simple cross-tree constraint editor is now implemented. In the long run, we may add a dedicated UI for adding/editing constraints, and add a context menu and filtering options for the constraints.