Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManifoldCAD doesn't work on Firefox before 111 #328

Closed
pca006132 opened this issue Feb 18, 2023 · 7 comments
Closed

ManifoldCAD doesn't work on Firefox before 111 #328

pca006132 opened this issue Feb 18, 2023 · 7 comments

Comments

@pca006132
Copy link
Collaborator

https://bugzilla.mozilla.org/show_bug.cgi?id=1247687

The worker type: 'module' is only recently implemented (111 is not yet released), not sure if we want this on the website as some users may still use older versions of firefox in the near future.

@elalish
Copy link
Owner

elalish commented Feb 19, 2023

Wow, that bug was opened 7 years ago. Man, when Safari implements something first, you know you've really gotten behind.

I haven't really been worrying too much about cross-browser testing, but it's not a bad idea. Still, I'm not sure how ugly the work around for this will be. I'm tempted to just not worry about it - maybe put up a message if their browser is an unsupported version. What do you think?

@pca006132
Copy link
Collaborator Author

Yeah I don't usually worry about cross-browser testing either (I used to even test IE, but that was years ago), but the problem is that my main driver is firefox :P

Why do we have to use modules though? I think if they allowed this bug to stay opened for so long, this should be something that can be worked around easily?

@elalish
Copy link
Owner

elalish commented Feb 19, 2023

Yeah, if it's easy to work around, let's do that. But after that ES6 module update, I really like modules a lot better - the code is nice and clean.

@elalish
Copy link
Owner

elalish commented Mar 17, 2023

Huh, I just tried this with Firefox 111 and it's still failing with import declarations may only appear at top level of a module in worker.js. Maybe they didn't fix it completely?

@pca006132
Copy link
Collaborator Author

https://developer.mozilla.org/en-US/docs/Web/API/Worker/Worker

disabled From version 111: this feature is behind the dom.workers.modules.enabled preference (needs to be set to true). To change preferences in Firefox, visit about:config.

I haven't tried it yet though.

@elalish
Copy link
Owner

elalish commented Mar 17, 2023

Excellent, I just tried it and it does indeed work!

@pca006132
Copy link
Collaborator Author

I guess we can consider this as won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants