Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primitive renderers from common files in xy chart #2586

Closed
mariairiartef opened this issue Jan 20, 2025 · 0 comments · Fixed by #2603
Closed

Use primitive renderers from common files in xy chart #2586

mariairiartef opened this issue Jan 20, 2025 · 0 comments · Fixed by #2603
Assignees
Labels
:refactor Code refactor :xy Bar/Line/Area chart related

Comments

@mariairiartef
Copy link
Contributor

In the PR #2577, we extracted some primitive renderers from the /packages/charts/src/chart_types/xy_chart/renderer/canvas/primitives folder to the packages/charts/src/renderers/canvas/primitives folder.

We should use these primitive renderers from the packages/charts/src/renderers/canvas/primitives folder in the files that we can find in packages/charts/src/chart_types/xy_chart folder to avoid duplicates. Additionally, we should remove the primitive renderers that we have already extracted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:refactor Code refactor :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant