Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ID is not escaped in URI #1799

Closed
godefroi opened this issue Feb 3, 2016 · 3 comments
Closed

Document ID is not escaped in URI #1799

godefroi opened this issue Feb 3, 2016 · 3 comments

Comments

@godefroi
Copy link

godefroi commented Feb 3, 2016

When I call ElasticsearchClient.Index() with an id of "x.x.x.3/001", the URI that is called is this:

http://1.1.1.1:9200/myindexname/mydocumenttype/x.x.x.3/001

This did not seem to be an issue with the previous (1.7.x) version.

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 3, 2016

Are you using rc1?

@godefroi
Copy link
Author

godefroi commented Feb 3, 2016

Yes, 2.0.0-rc1. I should note that I'm not 100% sure that this is actually an issue for ES, it may well be that it works fine without escaping the slash character. I'm also not 100% sure that ES.NET 1.7.x did escape the slash; if ES works ok with the slash unescaped, it may very well be that ES.NET 1.7.x did not escape it.

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 4, 2016

Thanks a ton for opening this issue, I whole fully inadequately implemented and tested this only for NEST not the lowlevel client 😢

This is now fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants