Add a latch to sync when all max upload tasks have been submitted #101203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we check the amount of active tasks on the prewarming executor, we need to verify that all the tasks have been actually submitted. Otherwise, we have a race in and amount of active tasks can be lower then the amount of submitted tasks. Fixes elastic#99124
arteam
added
>test
elasticsearchmachine
added
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Oct 23, 2023
...sticsearch/xpack/searchablesnapshots/cache/full/SearchableSnapshotsPrewarmingIntegTests.java
Outdated
Show resolved
Hide resolved
...sticsearch/xpack/searchablesnapshots/cache/full/SearchableSnapshotsPrewarmingIntegTests.java
Outdated
Show resolved
Hide resolved
…a/org/elasticsearch/xpack/searchablesnapshots/cache/full/SearchableSnapshotsPrewarmingIntegTests.java Co-authored-by: David Turner <[email protected]>
…a/org/elasticsearch/xpack/searchablesnapshots/cache/full/SearchableSnapshotsPrewarmingIntegTests.java Co-authored-by: David Turner <[email protected]>
|
Thank you David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we check the amount of active tasks on the prewarming executor, we need to verify that all the tasks have been actually submitted.
Otherwise, we have a race in and amount of active tasks can be lower then the amount of submitted tasks.
Fixes #99124