Hot-reloadable remote cluster credentials (with blocking call fix) #103215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>enhancement
:Security/Security
|
Hi @n1v0lg, I've created a changelog YAML for you. |
…elastic/elasticsearch into revert-103211-revert-102798-rcs2-reload
n1v0lg
commented
Dec 8, 2023
| * See {@link TransportReloadRemoteClusterCredentialsAction} for more context. | ||
| */ | ||
| private void reloadRemoteClusterCredentials(Settings settingsWithKeystore) { | ||
| final PlainActionFuture<ActionResponse.Empty> future = new PlainActionFuture<>() { |
There was a problem hiding this comment.
This is the only effective change -- in a serverless environment this method is called from within a cluster state update thread, which trips an assertion causing test failure.
|
Hi @n1v0lg, I've created a changelog YAML for you. |
DaveCTurner
reviewed
Dec 8, 2023
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/Security.java
Outdated
Show resolved
Hide resolved
DaveCTurner
reviewed
Dec 8, 2023
.../elasticsearch/xpack/core/security/action/settings/ReloadRemoteClusterCredentialsAction.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
Pinging @elastic/es-security (Team:Security) |
|
@elasticmachine run elasticsearch-ci/part-3-fips |
|
@elasticmachine update branch |
n1v0lg
added
the
auto-merge-without-approval
|
@elasticmachine update branch (failures unrelated) |
n1v0lg
removed
the
auto-merge-without-approval
n1v0lg
added
the
auto-merge-without-approval
elasticsearchmachine
deleted the
revert-103211-revert-102798-rcs2-reload
branch
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 15, 2024
Docs PR to accompany #103215. Resolves: ES-7625
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Feb 15, 2024
Docs PR to accompany elastic#103215. Resolves: ES-7625
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back #102798, with a tweak to avoid tripping on a blocking operation.
Only change compared to the original PR is 4072fac