Move expensive role building off transport thread #113020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>non-issue
:Security/Authorization
n1v0lg
changed the title
n1v0lg
changed the title
n1v0lg
commented
Sep 20, 2024
...security/src/main/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStore.java
Show resolved
Hide resolved
n1v0lg
commented
Sep 20, 2024
...ity/src/test/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStoreTests.java
Show resolved
Hide resolved
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
requested review from
slobodanadamovic
and removed request for
jakelandis
...security/src/main/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStore.java
Show resolved
Hide resolved
slobodanadamovic
approved these changes
Sep 23, 2024
|
@elasticmachine update branch |
n1v0lg
added
v8.16.0
auto-merge-without-approval
💚 Backport successful
|
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Sep 24, 2024
This PR moves role building off the transport thread to the generic thread pool, since role building can be expensive depending on role structure. Role building is CPU bound so this PR uses a `ThrottledTaskRunner` to limit the number of concurrent requests. I will explore adding a max queue limit in a follow up. Resolves: ES-9505
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 19, 2024
This PR moves role building off the transport thread to the generic thread pool, since role building can be expensive depending on role structure. Role building is CPU bound so this PR uses a `ThrottledTaskRunner` to limit the number of concurrent requests. I will explore adding a max queue limit in a follow up. Resolves: ES-9505 (cherry picked from commit 6cdd59b)
n1v0lg
added a commit
that referenced
this pull request
Nov 19, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 20, 2024
This PR moves role building off the transport thread to the generic thread pool, since role building can be expensive depending on role structure. Role building is CPU bound so this PR uses a `ThrottledTaskRunner` to limit the number of concurrent requests. I will explore adding a max queue limit in a follow up. Resolves: ES-9505 Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves role building off the transport thread to the generic thread pool, since role building can be expensive depending on role structure.
Role building is CPU bound so this PR uses a
ThrottledTaskRunnerto limit the number of concurrent requests. I will explore adding a max queue limit in a follow up.Resolves: ES-9505