Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] Move expensive role building off transport thread (#113020) #117002

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Nov 19, 2024

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

This PR moves role building off the transport thread to the generic
thread pool, since role building can be expensive depending on role
structure.

Role building is CPU bound so this PR uses a `ThrottledTaskRunner` to
limit the number of concurrent requests. I will explore adding a max
queue limit in a follow up.

Resolves: ES-9505
(cherry picked from commit 6cdd59b)
@n1v0lg n1v0lg self-assigned this Nov 19, 2024
@n1v0lg n1v0lg added :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >non-issue Team:Security Meta label for security team v8.16.1 auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Nov 19, 2024
@n1v0lg
Copy link
Contributor Author

n1v0lg commented Nov 19, 2024

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

There are no new commits on the base branch.

@n1v0lg n1v0lg removed the v8.16.2 label Nov 19, 2024
@n1v0lg n1v0lg merged commit 33b8fb1 into elastic:8.16 Nov 19, 2024
15 checks passed
@n1v0lg n1v0lg deleted the backport/8.16/pr-113020 branch November 19, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.16.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants