Avoid un-intended wildcard matches in ProfileIntegTests
#117888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>test
n1v0lg
changed the title
ProfileIntegTests test setup to avoid wildcard matchesProfileIntegTests
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
added
the
auto-merge-without-approval
This was referenced Dec 5, 2024
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Dec 5, 2024
The test setup for `ProfileIntegTests` is flawed, where the full name of a user can be a substring of other profile names (e.g., `SER` is a substring of `User <random-string>-space1`) -- when that's passed into suggest call with the `*` space, we get a match on all profiles, instead of only the one profile expected in the test, since we are matching on e.g. `SER*`. This PR restricts the setup to avoid the wildcard profile for that particular test. Closes: elastic#117782
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Dec 5, 2024
The test setup for `ProfileIntegTests` is flawed, where the full name of a user can be a substring of other profile names (e.g., `SER` is a substring of `User <random-string>-space1`) -- when that's passed into suggest call with the `*` space, we get a match on all profiles, instead of only the one profile expected in the test, since we are matching on e.g. `SER*`. This PR restricts the setup to avoid the wildcard profile for that particular test. Closes: elastic#117782
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Dec 5, 2024
The test setup for `ProfileIntegTests` is flawed, where the full name of a user can be a substring of other profile names (e.g., `SER` is a substring of `User <random-string>-space1`) -- when that's passed into suggest call with the `*` space, we get a match on all profiles, instead of only the one profile expected in the test, since we are matching on e.g. `SER*`. This PR restricts the setup to avoid the wildcard profile for that particular test. Closes: elastic#117782
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 5, 2024
The test setup for `ProfileIntegTests` is flawed, where the full name of a user can be a substring of other profile names (e.g., `SER` is a substring of `User <random-string>-space1`) -- when that's passed into suggest call with the `*` space, we get a match on all profiles, instead of only the one profile expected in the test, since we are matching on e.g. `SER*`. This PR restricts the setup to avoid the wildcard profile for that particular test. Closes: #117782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test setup for
ProfileIntegTestsis flawed, where the full name of a user can be a substring of other profile names (e.g.,SERis a substring ofUser <random-string>-space1) -- when that's passed into suggest call with the*space, we get a match on all profiles, instead of only the one profile expected in the test, since we are matching on e.g.SER*. This PR restricts the setup to avoid the wildcard profile for that particular test.Closes: #117782