Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Proposal: jsx-curly-spacing #11501

Closed
tsullivan opened this issue Apr 28, 2017 · 0 comments
Closed

ESLint Proposal: jsx-curly-spacing #11501

tsullivan opened this issue Apr 28, 2017 · 0 comments

Comments

@tsullivan
Copy link
Member

This is a proposal to implement the react/jsx-curly-spacing from https://github.com/yannickcr/eslint-plugin-react

This will help ensure consistency around spacing around props in JSX syntax. In other words, we shouldn't have a mix and match of code that looks like:

<MyComponent {...props} status={status}/>
<MyComponent { ...props } status={ status }/>

I would recommend implementing this rule as a warning instead of error, because the rule itself has issues which has created annoyances in the community:
jsx-eslint/eslint-plugin-react#857

As with all ESLint rules, stricter rules help readability of the code and make integrating changes smoother, because we won't see comments about this type of code in PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants