Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODOs sanitizer #34

Open
Veetaha opened this issue Sep 1, 2020 · 0 comments
Open

TODOs sanitizer #34

Veetaha opened this issue Sep 1, 2020 · 0 comments
Labels
good first issue Good for newcomers tech-debt

Comments

@Veetaha
Copy link
Contributor

Veetaha commented Sep 1, 2020 •
edited
Loading

The idea of sanitizing todos is for developers to leave TODO comments and have them all resolved or downgraded to FIXME
such that we never forget about the things we need to do until the pull request is merged.

The idea isn't new, in fact, I've just stolen it from rust-analyzer. The implementation is quite trivial. Here it is.
Though I would go for a more robust solution that uses rustc-ap-rustc_lexer crate for proper parsing.

The sanitizer is intended to be run as part of xtask crate tests.
@Veetaha Veetaha changed the title TODOs pre-commit santizer TODOs pre-commit sanitizer Sep 1, 2020
@Veetaha Veetaha changed the title TODOs pre-commit sanitizer TODOs sanitizer Sep 1, 2020
@Veetaha Veetaha added the good first issue Good for newcomers label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anelson @Veetaha