Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publisher-github readme to provide required permissions #3725

Closed
3 tasks done
steveoh opened this issue Oct 2, 2024 · 1 comment
Closed
3 tasks done

Update publisher-github readme to provide required permissions #3725

steveoh opened this issue Oct 2, 2024 · 1 comment

Comments

@steveoh
Copy link

steveoh commented Oct 2, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

The npm package does not document the required permissions it needs to function leading to errors in deployments

✖ [publisher-github] Running the publish command [FAILED: Resource not accessible by integration]
✖ Publishing distributables [FAILED: Resource not accessible by integration]

Proposed solution

update the readme to include the following permissions. I believe these are the minimum requirements.

permissions:
  id-token: write
  deployments: write
  contents: write

Alternatives considered

none

Additional information

I'm happy to contribute the doc change if you can verify the correct permissions.

@erickzhao
Copy link
Member

Let me know if this is ultimately incorrect, but I think all you need is contents: write to create a new release.

Ref electron-forge/electron-forge-docs@70b4de6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants