Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RcEdit destroys application without relocation table #70

Open
Macma77 opened this issue Dec 6, 2017 · 4 comments
Open

RcEdit destroys application without relocation table #70

Macma77 opened this issue Dec 6, 2017 · 4 comments

Comments

@Macma77
Copy link

Macma77 commented Dec 6, 2017

One of the future in EurekaLog is to reduce file size by removing relocation table.
When I set resources in such file RcEdit destroys application file.

In attachment I prepared simple application orginal with removed relocation table and one with resources applied via RcEdit (rcedit.exe EurekaLogRcEditTest.exe --set-version-string Test Test)

EurekaLogRcEditTest.zip

@thomasmfields
Copy link

I'm also seeing issues with rcedit corrupting my executable after setting the version string. It could be this issue. Is it possible to get a fix?

@erik-helmers
Copy link

Same here. Happens when building Node.JS apps with pkg.
Hope this could be fixed :)

@m4heshd
Copy link

m4heshd commented Aug 19, 2019

If anybody's wondering, pretty much all resource editing tools destroy the integrity of executable files except the latest version of resource hacker. Simply run the following command line to change an icon.

reshacker.exe -open "Your.exe" -save "Your.exe" -action addoverwrite -res "Your_icon.ico" -mask ICONGROUP,1,1033

I've tested every resource editor out there and this is the only one that worked.

@rversteegen
Copy link
Contributor

rcedit relies on the BeginUpdateResource/UpdateResource/EndUpdateResource winapi functions to do all the actual work of parsing and modifying the exe file format. I suspect those functions can't handle such .exe files. Which means this bug would have to be marked WontFix, because rcedit would have to be rewritten to fix it. Use ResourceHacker instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants