Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-sandbox doesn't work, but -n or --noSandbox does #1003

Open
abeluck opened this issue Aug 11, 2023 · 1 comment · May be fixed by #1018
Open

--no-sandbox doesn't work, but -n or --noSandbox does #1003

abeluck opened this issue Aug 11, 2023 · 1 comment · May be fixed by #1018
Labels
bug Something isn't working

Comments

@abeluck
Copy link

abeluck commented Aug 11, 2023

Describe the bug
The help says:

      -n --no-sandbox             Disable sandbox on bundled Chromium on Linux platforms - not recommended  [default: false]

However passing --no-sandbox doesn't work. By reading the code I saw that --noSandbox is referenced, and this flag does indeed work.

To Reproduce
Steps to reproduce the behavior:

  1. Execute cli command sudo pwa-asset-generator logo.html --no-sandbox
  2. See error
...
[0811/111857.270844:ERROR:zygote_host_impl_linux.cc(90)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md
 😭

Expected behavior
The documented command line flag should work.

System (please complete the following information):

  • OS: linux
  • node version: v18.16.0
  • npm version: 9.5.1
  • cli version: 6.3.1
@abeluck abeluck added bug Something isn't working needs verification Bug needs to be verified with reproduction labels Aug 11, 2023
@atjn atjn removed the needs verification Bug needs to be verified with reproduction label Aug 24, 2024
@atjn
Copy link
Collaborator

atjn commented Aug 24, 2024

I can reproduce this, the problem is that --no-sandbox is parsed as --sandbox false, which is a different flag name.

@atjn atjn linked a pull request Aug 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): support --no-sandbox elegantapp/pwa-asset-generator
2 participants
@abeluck @atjn