Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for app screenshots #1019

Open
frederikhors opened this issue Sep 8, 2024 · 2 comments
Open

Support for app screenshots #1019

frederikhors opened this issue Sep 8, 2024 · 2 comments
Labels
enhancement Code improvement, refactor

Comments

@frederikhors
Copy link

Why do I have this error in Chrome DevTools's Manifest tab?

image

Richer PWA Install UI won't be available on desktop. Please add at least one screenshot with the form_factor set to wide.

Richer PWA Install UI won't be available on mobile. Please add at least one screenshot for which form_factor is not set or set to value other than wide.

Can I generate these screenshow with pwa-asset-generator too?

@frederikhors frederikhors added bug Something isn't working needs verification Bug needs to be verified with reproduction labels Sep 8, 2024
@atjn
Copy link
Collaborator

atjn commented Sep 8, 2024

You need to take screenshots of your app and add them to your manifest. PAG does not take screenshots of your app, and realistically can never do that because only you know which parts of the app you want to showcase. You can read more about the feature here: https://developer.chrome.com/blog/richer-pwa-installation/

@atjn atjn added enhancement Code improvement, refactor and removed bug Something isn't working needs verification Bug needs to be verified with reproduction labels Sep 8, 2024
@atjn
Copy link
Collaborator

atjn commented Sep 8, 2024

Leaving this open because it might make sense for PAG to let the developer link to screenshots that should be included in the manifest.

@atjn atjn changed the title Why do I have this error in Chrome DevTools's Manifest tab? Support for app screenshots Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code improvement, refactor
Projects
None yet
Development

No branches or pull requests

2 participants