Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sentry reporting further #3306

Open
matrixbot opened this issue Nov 2, 2024 · 0 comments
Open

Update Sentry reporting further #3306

matrixbot opened this issue Nov 2, 2024 · 0 comments
Labels
good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @S7evinK at matrix-org/dendrite#3306.

matrix-org/dendrite#3305 made reporting errors a bit better, but there are still places in the code where we CaptureException in go routines, possibly still sending garbage to Sentry.
For reference: https://docs.sentry.io/platforms/go/usage/concurrency/

It may also make sense to check if we even should report said errors to sentry, as e.g. we should always be able json.Unmarshal things we sent to JetStream ourselves.
@matrixbot matrixbot added good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot