-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sticker panel renders blank, console shows a creatorUserID error #35
Comments
@andybalaam can you link the PR we think caused this please |
We think it was broken by:
And it is hopefully going to be fixed by: |
I believe this is fixed by matrix-org/matrix-react-sdk#10423 - please re-open if not. |
Thanks @ashughes1 - re-opening. |
@justinbot any idea what's going on here? |
N.B. Opening the sticker picker for me doesn't show any errors in the console or any attempts to open an iframe from the network logs. I don't think this is a integration manager issue? |
@ashughes1 Can you confirm what version of Element Web you're seeing this issue on? As far as the second issue where stickers don't appear right after adding, this is unrelated to the original issue but due to the sticker picker not refreshing (element-hq/element-web#23295). Usually if you navigate rooms or refresh the page they will appear. |
@andybalaam did matrix-org/matrix-react-sdk#10423 actually make it to an Element Web release yet? It hasn't appeared in any changelogs... I tested this again and I do see the issue with |
@justinbot the fix is included in today's release candidate v1.11.29-rc.1 and will be released in the next release on 11th April 2023, v1.11.29. |
@ashughes1 which version were you testing? |
Sorry for the delay. I am not seeing this on develop but I am on production with Element 1.11.30, Olm 3.2.12. |
@Half-Shot I don't think this needs design. It's a normal bug... |
OK, in that case let's say it's closed in today's release 1.11.31 (coming soon), and if you see it again there, please re-open again. Thank you! |
I think I have figured out what is going on here, please advise if I should reopen. On app.element.io with Enhanced Tracking Protection enabled (or in a Private Browsing window) the sticker panel loads blank and shows the errors below in the Web Console. If I disable Enhanced Tracking Protection the panel loads. However, on dev.element.io the panel loads perfectly fine with ETP enabled. I'm not sure what is different in this case. Errors in web console with ETP enabled on app.element.ioError when enabling the integration:
Errors when opening the sticker panelHTTP GET error:
MIME type error:
Request timeout error in PostmessageTransport.js:
|
@ashughes1 That looks similar to #28 where tracking prevention is blocking cookies in cross-origin iframes which breaks authentication. Do other widgets work with Enhanced Tracking Protection enabled? |
@justinbot Jitsi Meet seems to work but the others do not with ETP turned on. |
Thanks. Unfortunately this is a difficult restriction we don't have a solution for at the moment, but you may be able to add an exception to ETP. |
Steps to reproduce
I didn't have Stickers enabled yet so this assumes you're starting from the same point.
Outcome
What did you expect?
I expected to be able to add stickers to my message
What happened instead?
In some instances the UI thinks I haven't added stickers yet and prompts me to add some.
![Screenshot from 2023-03-08 11-33-03](https://user-images.githubusercontent.com/766595/223827228-4f3a80f2-7c72-42ff-97e0-990370f733c4.png)
In other instances the panel renders completely empty (no text, images, buttons or links) and the following error shows in the Console:
Operating system
OpenSUSE Micro OS
Browser information
Firefox 110.0.1 (Flatpak edition)
URL for webapp
Happens with both develop.element.io and a private instance
Application version
Element version: v1.11.25-rc.1-r2.2 Olm version: 3.2.12
Homeserver
matrix.org and element.io
Will you send logs?
No
The text was updated successfully, but these errors were encountered: