Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UserList more keyboard accessible #11285

Open
t3chguy opened this issue Nov 1, 2019 · 7 comments
Open

Make UserList more keyboard accessible #11285

t3chguy opened this issue Nov 1, 2019 · 7 comments
Labels
A11y A-Member-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist X-Blocked

Comments

@t3chguy
Copy link
Member

t3chguy commented Nov 1, 2019

It should probably be a listbox widget with arrow-keys for navigation within the widget to not introduce N tabstops to the application.

@t3chguy t3chguy added the I18n label Nov 1, 2019
@jugglinmike
Copy link

The MemberList component currently has two distinct lists of members: joined members and invited members. Should we:

  • Include both in a single ListBox? If so, I think we'll move the list expansion buttons (labeled "and N others...") out of the document focus ring and instead make it reachable via ListBox navigation
  • Implement each as distinct ListBoxes? In this case, should the list expansion buttons remain in the document focus ring?

The current interface design tends to suggest the first option because both lists share a single vertical scroll bar and because both lists are subject to the same search filter. I don't want to make any assumptions, though.

@t3chguy
Copy link
Member Author

t3chguy commented Jun 19, 2020

Based on #983 the underlying interaction may be changing anyhow

@jugglinmike
Copy link

Drat. Does that issue obviate this one? That one is much older; would you happen to know if anyone is working on it? Should I give it a shot, instead?

@t3chguy
Copy link
Member Author

t3chguy commented Jun 19, 2020

I will run a quick query by design early next week for any preliminary plans for the right panel and will get back to you

@jugglinmike
Copy link

Thanks!

@pvagner
Copy link
Contributor

pvagner commented Dec 9, 2021

If the question is still relevant today, I'd say we would like to have single list with keyboard and focus handling identical to room list.
Joined Members and Invited members should be list items with aria-level set to 0 and the member tiles should be list items with aria-level set to 1.
When member list tiles have focus up / down / home /end change the focus, enter activates focused item.
When either joined members item or invited members item has keyboard focus it should be possible to use the same set of navigation keys and also left arrow key to collapse and right arrow key to expand. Whether a node is expanded should be communicated by using aria-expanded property.
I'd like to have the same ux we do have with the room list.
Hopefully I haven't forgotten something important.
Thank you.

@t3chguy t3chguy added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 25, 2022
@t3chguy
Copy link
Member Author

t3chguy commented May 12, 2023

Blocked on #983

@t3chguy t3chguy removed their assignment Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-Member-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist X-Blocked
Projects
None yet
Development

No branches or pull requests

4 participants