Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call hangups are treated as unread messages #15393

Closed
dbkr opened this issue Oct 6, 2020 · 9 comments · Fixed by matrix-org/matrix-js-sdk#1872
Closed

call hangups are treated as unread messages #15393

dbkr opened this issue Oct 6, 2020 · 9 comments · Fixed by matrix-org/matrix-js-sdk#1872
Labels
A-VoIP O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Oct 6, 2020

No description provided.

@dbkr dbkr added T-Defect P1 S-Tolerable Low/no impact on users A-VoIP labels Oct 6, 2020
@SimonBrandner SimonBrandner mentioned this issue Feb 28, 2021
Closed
@jryans jryans removed the P1 label Apr 21, 2021
@SimonBrandner
Copy link
Contributor

This is a problem for all m.call events

@t3chguy
Copy link
Member

t3chguy commented Jun 23, 2021

Hmm, https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/Unread.ts#L40-L41 answer/hangup shouldn't

@SimonBrandner
Copy link
Contributor

The count displayed in the room-tile actually depends on the js-sdk's Room::getUnreadNotificationCount()

@SimonBrandner
Copy link
Contributor

https://github.com/SimonBrandner/matrix-react-sdk//blob/develop/src/stores/notifications/RoomNotificationState.ts#L79

@SimonBrandner
Copy link
Contributor

Note: what Dave probably meant here is: "call hangups are treated as notifications", hence the confusion above ^

@SimonBrandner SimonBrandner mentioned this issue Jun 25, 2021
Closed
@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 and removed S-Tolerable Low/no impact on users labels Aug 2, 2021
This was referenced Aug 2, 2021
Closed
Closed
@SimonBrandner SimonBrandner added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Aug 6, 2021
@novocaine novocaine added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 25, 2021
@novocaine
Copy link
Contributor

Downgrading to S-minor as this does not significantly degrade major functionality; it's just a bit annoying

@SimonBrandner SimonBrandner removed the P2 label Aug 25, 2021
@SimonBrandner SimonBrandner mentioned this issue Aug 26, 2021
Merged
@turt2live
Copy link
Member

PR reverted; reopening

@turt2live turt2live reopened this Sep 7, 2021
This was referenced Oct 15, 2021
Closed
Closed
@SimonBrandner
Copy link
Contributor

It seems the only way to fix this is to use to-device events

@SimonBrandner SimonBrandner mentioned this issue Oct 29, 2021
Closed
@SimonBrandner
Copy link
Contributor

It seems you're not the only one to have come across this bug, as it's been reported previously. I'm going to close this issue now so we can focus on the older issue. Please watch, vote or comment on that issue if there is any additional information you can provide.

Duplicate of #7941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-VoIP O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
6 participants
@novocaine @jryans @dbkr @turt2live @t3chguy @SimonBrandner