Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App fails to recover rapidly from UISIs #25980

Open
ara4n opened this issue Aug 16, 2023 · 0 comments
Open

App fails to recover rapidly from UISIs #25980

ara4n opened this issue Aug 16, 2023 · 0 comments
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement

Comments

@ara4n
Copy link
Member

ara4n commented Aug 16, 2023

Steps to reproduce

  1. A bad case of If you restart (e.g. upgrade) Element while it's waiting to process a m.room_key, it'll drop it and you'll get UISIs #23113 made almost all my E2EE messages UISI.
  2. To work around it, I opened up an old EW instance, which thankfully received all the megolm keys correctly and stored them to online backup.
  3. However, looking at EW, it still showed all the messages as UISI, and we no longer provide a way to explicitly request decryption. Over the next hour or so, some of the resolved (showing grey shields as expected), but not all. I couldn't spot the pattern.

Apparently we only request keys from online backup (or keyshare?) when a message is first loaded. This makes the feature almost useless, given by definition you don't have the keys when the message is first loaded. I'm assuming other sessions are getting pulled in if I backapaginate?

Outcome

What did you expect?

UISIs should try to resolve themselves from backup whenever they're shown to the user.

What happened instead?

UISIs only try to resolve when they are first received, making them very hard to flush out, especially now we don't have a manual "retry decryption" button any more, since matrix-org/matrix-react-sdk#11027

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

develop

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Aug 16, 2023
@dbkr dbkr added A-E2EE T-Enhancement O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed T-Defect labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants