Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker builds to not fail #9701

Closed
turt2live opened this issue May 13, 2019 · 1 comment · Fixed by #9736
Closed

Fix Docker builds to not fail #9701

turt2live opened this issue May 13, 2019 · 1 comment · Fixed by #9736
Assignees
@turt2live
Labels
A-Packaging Packaging, signing, releasing P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement

Comments

@turt2live
Copy link
Member

See also #9606
See also #9653

The issue is that Docker Hub's infrastructure can't sustain our network requirements, so we have to build our own and publish them. We should do it automatically with Buildkite.

Although a nice to have for the next release, we can always manually build images for that release.
@turt2live turt2live added feature P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels May 13, 2019
@turt2live turt2live self-assigned this May 13, 2019
@turt2live
Copy link
Member Author

https://github.com/buildkite-plugins/docker-login-buildkite-plugin is required to provide credentials to the agent, which needs an agent hook. We'd otherwise be using https://github.com/buildkite-plugins/docker-compose-buildkite-plugin to build&publish the image.

@turt2live turt2live mentioned this issue May 15, 2019
Merged
@turt2live turt2live changed the title Build & publish Docker images in Buildkite Fix Docker builds to not fail May 15, 2019
@jryans jryans added the A-Packaging Packaging, signing, releasing label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Packaging Packaging, signing, releasing P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Dockerfile work for develop and other branches element-hq/element-web
2 participants
@jryans @turt2live