Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule dark mode #233

Merged
merged 26 commits into from
Sep 29, 2020
Merged

Schedule dark mode #233

merged 26 commits into from
Sep 29, 2020
+133 −14

Conversation

meisenzahl
Copy link
Member

Related to elementary/gala#863

@meisenzahl
Copy link
Member Author

My changes have slightly messed up the layout.

Screenshot from 2020-06-30 20 31 39

Screenshot from 2020-06-30 20 31 49

Screenshot from 2020-06-30 20 31 54

@meisenzahl
Copy link
Member Author

Peek 2020-06-30 21-30

@meisenzahl
Copy link
Member Author

Peek 2020-07-01 20-59

@4jNsY6fCVqZv 4jNsY6fCVqZv mentioned this pull request Jul 2, 2020
Open
3 tasks
@meisenzahl
Copy link
Member Author

Moved logic from elementary/gala#863 to elementary/settings-daemon#7

@meisenzahl
Copy link
Member Author

Screenshot of current version with merged master and fixed layout.

Screenshot von 2020-08-20 18 32 23

@meisenzahl meisenzahl marked this pull request as ready for review August 20, 2020 16:43
@danirabbit danirabbit added the Needs Design Waiting on input or designs from the UX team label Aug 21, 2020
danirabbit
danirabbit requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interaction here makes sense to me. Nice work! Left some inline comments to adjust the layout a bit and some minor code cleanup

src/Views/Appearance.vala Outdated Show resolved Hide resolved
src/Views/Appearance.vala Outdated Show resolved Hide resolved
src/Views/Appearance.vala Outdated Show resolved Hide resolved
src/Views/Appearance.vala Outdated Show resolved Hide resolved
src/Views/Appearance.vala Outdated Show resolved Hide resolved
src/Views/Appearance.vala Outdated Show resolved Hide resolved
@meisenzahl
Copy link
Member Author

@danrabbit many thanks for the suggestions! They simplify the code once again :)

And the small changes in the layout look pretty good.

@meisenzahl
Copy link
Member Author

@danrabbit I would be happy if you could review this as well 😅

danirabbit
danirabbit approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some future design tweaks we can make, but this works as expected. I'm happy to merge as is so we can use the feature and we can iterate as we go :)

@danirabbit danirabbit merged commit 90b9074 into elementary:master Sep 29, 2020
@meisenzahl meisenzahl deleted the schedule-dark-mode branch September 29, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
Needs Design Waiting on input or designs from the UX team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meisenzahl @danirabbit