[26544] dialog on mail change of activated mediorder patient #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
col-panic
requested changes
Aug 19, 2024
| @@ -161,6 +167,21 @@ public String getText(Object element) { | |||
|
|
|||
| setUnlocked(LocalLockServiceHolder.get().isLocked(pat)); | |||
|
|
|||
| textEmail.addVerifyListener(new VerifyListener() { | |||
There was a problem hiding this comment.
Das müsstest du als Lambda implementieren können, da VerifyListener ein FunctionalInterface ist. Das reduziert den ganzen Boilerplate Code hier ...
| @@ -424,14 +437,20 @@ private void addListener(Kontakt kontakt) { | |||
| try { | |||
| boolean mandatorEditGuard = kontakt.istMandant(); | |||
|
|
|||
| List<ISticker> lSticker = StickerServiceHolder.get().getStickers(kontakt.toIContact().asIPatient()); | |||
| boolean hasSticker = lSticker.stream().anyMatch(sticker -> sticker.getId().equals("activate_mediorder")); | |||
There was a problem hiding this comment.
Wir haben jetzt schon an ein paar Stellen den literal String activate_mediorder - wir kopieren den immer, das gefällt mir nicht. Hast du einen Vorschlag wie und wo wir den als Konstante in einer Klasse ablegen können?
Dann kannst du das dort dokumentieren, und es ist auch leicht referenzen darauf zu finden?!
There was a problem hiding this comment.
Ich würde eine Constants Klasse in ch.elexis.core.ui.mediorder vorschlagen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.