Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permutation Importance warning scikit 0.25 #12

Open
ThomasWolf0701 opened this issue Apr 11, 2021 · 5 comments
Open

permutation Importance warning scikit 0.25 #12

ThomasWolf0701 opened this issue Apr 11, 2021 · 5 comments

Comments

@ThomasWolf0701
Copy link

When running permutation Importance I get the following warning:

C:\Users\Thomas Wolf\anaconda3\lib\site-packages\sklearn\utils\validation.py:70: FutureWarning: Pass classifier=False as keyword args. From version 0.25 passing these as positional arguments will result in an error
FutureWarning)
C:\Users\Thomas Wolf\anaconda3\lib\site-packages\sklearn\utils\validation.py:70: FutureWarning: Pass classifier=False as keyword args. From version 0.25 passing these as positional arguments will result in an error
FutureWarning)

@zeromh
Copy link

zeromh commented Sep 17, 2021

Same! Would love to see this fixed before it breaks.

@johncant
Copy link

johncant commented Dec 6, 2021

Looks like this has been fixed in the latest master

@ThomasWolf0701
Copy link
Author

Looks like this has been fixed in the latest master

Still looks the same as before to me. The pypi version is still the old one too.

@ThomasWolf0701
Copy link
Author

cv = check_cv(self.cv, y, classifier=is_classifier(self.estimator)) seems to be the culprit in the permutation_importance.py function.

@ThomasWolf0701
Copy link
Author

cv = check_cv(self.cv, y, is_classifier(self.estimator))
TypeError: check_cv() takes from 0 to 2 positional arguments but 3 were given

Is the error message with scikit-learn 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants