Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor Devise paranoid mode #21

Open
eliotsykes opened this issue Apr 17, 2017 · 4 comments
Open

Favor Devise paranoid mode #21

eliotsykes opened this issue Apr 17, 2017 · 4 comments

Comments

@eliotsykes
Copy link
Owner

  # It will change confirmation, password recovery and other workflows
  # to behave the same regardless if the e-mail provided was right or wrong.
  # Does not affect registerable.
  config.paranoid = true

Does Clearance have a similar option to mention?

@tute
Copy link

tute commented Apr 18, 2017

cc @derekprior for context user enumeration type of attacks and Clearance. Thank you!

@derekprior
Copy link

This is how Clearance works by default. You can still enumerate used email addresses in registration though as you'll get a message about the email address being in use. I think this is similar to devise.

@eliotsykes
Copy link
Owner Author

Thanks @tute & @derekprior. Great to discover Clearance works like this by default. (Devise requires opt-in to paranoid mode.)

I'll add something to the checklist about both shortly.

(for reference Devise.paranoid defaulting to false https://github.com/plataformatec/devise/blob/f7b6d786066cef2f5e8d2ce9c6b6cc83918580eb/lib/devise.rb#L281-L283)

@eliotsykes
Copy link
Owner Author

PR #26 opened to cover this. Leaving it open for a day or two for feedback.

jcasimir pushed a commit to turingschool/census that referenced this issue Apr 26, 2018
Why:

* leaking existing emails if not necessary is a bummer -
  eliotsykes/rails-security-checklist#21

This change addresses the need by:

* turning on Devise's paranoid mode and sending an email when a password
  is changed.

https://trello.com/c/EOF91FHv/338-make-census-send-password-was-changed-emails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants