Allow use of Heroku config for ImageMagick version #16
Conversation
| VENDOR_DIR="$BUILD_DIR/vendor" | ||
| mkdir -p $VENDOR_DIR | ||
| INSTALL_DIR="$VENDOR_DIR/imagemagick" | ||
| mkdir -p $INSTALL_DIR | ||
| IMAGE_MAGICK_VERSION="${IMAGE_MAGICK_VERSION:-6.9.5-10}" | ||
| if [ -d $ENV_DIR ]; then |
There was a problem hiding this comment.
Could we collapse this conditional and the one two lines down together into a single -f test? I think that would also make it so we only have to specify the default version once.
There was a problem hiding this comment.
I did run it on a live app, and it worked to install the right version of ImageMagick. But the app failed because ImageMagick requires some version-specific configuration setup that I couldn't figure out how to add via the buildback. So I ended up using a different approach (Linux 'file' command instead of 'identify') and abandoned this direction.
There was a problem hiding this comment.
like
[ -f "${ENV_DIR}/IMAGE_MAGICK_VERSION" ] && export "IMAGE_MAGICK_VERSION=$(cat "${ENV_DIR}/IMAGE_MAGICK_VERSION")"
IMAGE_MAGICK_VERSION="${IMAGE_MAGICK_VERSION:-6.9.5-10}"I wrote a function for this:
load_env_vars() {
local env_var; env_var="${1:-}"
until [ -z "$env_var" ]; do [ -f "$ENV_DIR/$env_var" ] && export "$env_var=$(cat "$ENV_DIR/$env_var")"; shift ; env_var="${1:-}" ; done
}
load_env_vars "IMAGE_MAGICK_VERSION" "OTHER_THING"
|
@jayzes this heroku-buildpack-jemalloc fork accommodates both stack and version. https://github.com/gaffneyc/heroku-buildpack-jemalloc/blob/master/bin/compile heroku-18 was just released gaffneyc/heroku-buildpack-jemalloc@28198d9 perhaps this buildpack could incorporate some of the progress made there. |
Allows you to set the
IMAGE_MAGICK_VERSIONin Heroku config and it will work.(Previous implementation assumed that config settings appear as environment variables to build packs, but they are actually exposed in a set of files in the ENV_VAR parameter, as per Heroku docs.)