From 608860fb36d0ac0700ebdb0a4ee08ed237d58861 Mon Sep 17 00:00:00 2001 From: Dario Nieuwenhuis Date: Thu, 7 Sep 2023 19:43:57 +0200 Subject: [PATCH] Remove feature(impl_trait_projections) from async traits. --- .../src/flash/partition/asynch.rs | 6 ++-- embassy-embedded-hal/src/lib.rs | 2 +- .../src/shared_bus/asynch/i2c.rs | 6 +++- .../src/shared_bus/asynch/spi.rs | 10 +++++-- embassy-lora/src/lib.rs | 2 +- embassy-net/src/dns.rs | 7 ++--- embassy-net/src/lib.rs | 2 +- embassy-net/src/tcp.rs | 20 ++++++------- embassy-nrf/src/buffered_uarte.rs | 16 +++++----- embassy-nrf/src/gpiote.rs | 20 ++++++------- embassy-nrf/src/lib.rs | 2 +- embassy-nrf/src/qspi.rs | 6 ++-- embassy-nrf/src/twim.rs | 8 ++--- embassy-rp/src/flash.rs | 6 ++-- embassy-rp/src/gpio.rs | 30 +++++++++---------- embassy-rp/src/i2c.rs | 8 ++--- embassy-rp/src/lib.rs | 2 +- embassy-rp/src/spi.rs | 10 +++---- embassy-rp/src/uart/buffered.rs | 16 +++++----- embassy-stm32/src/exti.rs | 11 +++---- embassy-stm32/src/flash/asynch.rs | 12 ++++---- embassy-stm32/src/flash/f4.rs | 6 ++-- embassy-stm32/src/i2c/v2.rs | 8 ++--- embassy-stm32/src/sdmmc/mod.rs | 9 ++---- embassy-stm32/src/spi/mod.rs | 10 +++---- embassy-stm32/src/usart/buffered.rs | 16 +++++----- embassy-stm32/src/usart/mod.rs | 8 ++--- embassy-stm32/src/usart/ringbuffered.rs | 2 +- embassy-sync/src/lib.rs | 2 +- embassy-sync/src/pipe.rs | 14 ++++----- examples/std/src/bin/net_ppp.rs | 2 +- 31 files changed, 141 insertions(+), 138 deletions(-) diff --git a/embassy-embedded-hal/src/flash/partition/asynch.rs b/embassy-embedded-hal/src/flash/partition/asynch.rs index 5920436dd9..504ab22565 100644 --- a/embassy-embedded-hal/src/flash/partition/asynch.rs +++ b/embassy-embedded-hal/src/flash/partition/asynch.rs @@ -49,7 +49,7 @@ impl ErrorType for Partition<'_, M, T> { impl ReadNorFlash for Partition<'_, M, T> { const READ_SIZE: usize = T::READ_SIZE; - async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Error> { if offset + bytes.len() as u32 > self.size { return Err(Error::OutOfBounds); } @@ -67,7 +67,7 @@ impl NorFlash for Partition<'_, M, T> { const WRITE_SIZE: usize = T::WRITE_SIZE; const ERASE_SIZE: usize = T::ERASE_SIZE; - async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Error> { if offset + bytes.len() as u32 > self.size { return Err(Error::OutOfBounds); } @@ -76,7 +76,7 @@ impl NorFlash for Partition<'_, M, T> { flash.write(self.offset + offset, bytes).await.map_err(Error::Flash) } - async fn erase(&mut self, from: u32, to: u32) -> Result<(), Self::Error> { + async fn erase(&mut self, from: u32, to: u32) -> Result<(), Error> { if to > self.size { return Err(Error::OutOfBounds); } diff --git a/embassy-embedded-hal/src/lib.rs b/embassy-embedded-hal/src/lib.rs index 3aad838bdb..a82ce2a07b 100644 --- a/embassy-embedded-hal/src/lib.rs +++ b/embassy-embedded-hal/src/lib.rs @@ -1,5 +1,5 @@ #![cfg_attr(not(feature = "std"), no_std)] -#![cfg_attr(feature = "nightly", feature(async_fn_in_trait, impl_trait_projections, try_blocks))] +#![cfg_attr(feature = "nightly", feature(async_fn_in_trait, try_blocks))] #![warn(missing_docs)] //! Utilities to use `embedded-hal` traits with Embassy. diff --git a/embassy-embedded-hal/src/shared_bus/asynch/i2c.rs b/embassy-embedded-hal/src/shared_bus/asynch/i2c.rs index 87e8a4304f..45e385808f 100644 --- a/embassy-embedded-hal/src/shared_bus/asynch/i2c.rs +++ b/embassy-embedded-hal/src/shared_bus/asynch/i2c.rs @@ -151,7 +151,11 @@ where Ok(()) } - async fn transaction(&mut self, address: u8, operations: &mut [i2c::Operation<'_>]) -> Result<(), Self::Error> { + async fn transaction( + &mut self, + address: u8, + operations: &mut [i2c::Operation<'_>], + ) -> Result<(), I2cDeviceError> { let mut bus = self.bus.lock().await; bus.set_config(&self.config); bus.transaction(address, operations) diff --git a/embassy-embedded-hal/src/shared_bus/asynch/spi.rs b/embassy-embedded-hal/src/shared_bus/asynch/spi.rs index 030392183e..32ae5b5049 100644 --- a/embassy-embedded-hal/src/shared_bus/asynch/spi.rs +++ b/embassy-embedded-hal/src/shared_bus/asynch/spi.rs @@ -62,7 +62,10 @@ where BUS: spi::SpiBus, CS: OutputPin, { - async fn transaction(&mut self, operations: &mut [spi::Operation<'_, u8>]) -> Result<(), Self::Error> { + async fn transaction( + &mut self, + operations: &mut [spi::Operation<'_, u8>], + ) -> Result<(), SpiDeviceError> { let mut bus = self.bus.lock().await; self.cs.set_low().map_err(SpiDeviceError::Cs)?; @@ -128,7 +131,10 @@ where BUS: spi::SpiBus + SetConfig, CS: OutputPin, { - async fn transaction(&mut self, operations: &mut [spi::Operation<'_, u8>]) -> Result<(), Self::Error> { + async fn transaction( + &mut self, + operations: &mut [spi::Operation<'_, u8>], + ) -> Result<(), SpiDeviceError> { let mut bus = self.bus.lock().await; bus.set_config(&self.config); self.cs.set_low().map_err(SpiDeviceError::Cs)?; diff --git a/embassy-lora/src/lib.rs b/embassy-lora/src/lib.rs index c23d1d0dd2..0a9cea16ec 100644 --- a/embassy-lora/src/lib.rs +++ b/embassy-lora/src/lib.rs @@ -1,5 +1,5 @@ #![no_std] -#![feature(async_fn_in_trait, impl_trait_projections)] +#![feature(async_fn_in_trait)] //! embassy-lora holds LoRa-specific functionality. pub(crate) mod fmt; diff --git a/embassy-net/src/dns.rs b/embassy-net/src/dns.rs index fdd45b3141..bad5c06d79 100644 --- a/embassy-net/src/dns.rs +++ b/embassy-net/src/dns.rs @@ -79,7 +79,7 @@ where &self, host: &str, addr_type: embedded_nal_async::AddrType, - ) -> Result { + ) -> Result { use embedded_nal_async::{AddrType, IpAddr}; let qtype = match addr_type { AddrType::IPv6 => DnsQueryType::Aaaa, @@ -98,10 +98,7 @@ where } } - async fn get_host_by_address( - &self, - _addr: embedded_nal_async::IpAddr, - ) -> Result, Self::Error> { + async fn get_host_by_address(&self, _addr: embedded_nal_async::IpAddr) -> Result, Error> { todo!() } } diff --git a/embassy-net/src/lib.rs b/embassy-net/src/lib.rs index c2575267ce..a8b9ab89df 100644 --- a/embassy-net/src/lib.rs +++ b/embassy-net/src/lib.rs @@ -1,5 +1,5 @@ #![cfg_attr(not(feature = "std"), no_std)] -#![cfg_attr(feature = "nightly", feature(async_fn_in_trait, impl_trait_projections))] +#![cfg_attr(feature = "nightly", feature(async_fn_in_trait))] #![warn(missing_docs)] #![doc = include_str!("../README.md")] diff --git a/embassy-net/src/tcp.rs b/embassy-net/src/tcp.rs index a12fd382a2..a81aafb67f 100644 --- a/embassy-net/src/tcp.rs +++ b/embassy-net/src/tcp.rs @@ -536,17 +536,17 @@ mod embedded_io_impls { } impl<'d> embedded_io_async::Read for TcpSocket<'d> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { self.io.read(buf).await } } impl<'d> embedded_io_async::Write for TcpSocket<'d> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.io.write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.io.flush().await } } @@ -556,7 +556,7 @@ mod embedded_io_impls { } impl<'d> embedded_io_async::Read for TcpReader<'d> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { self.io.read(buf).await } } @@ -566,11 +566,11 @@ mod embedded_io_impls { } impl<'d> embedded_io_async::Write for TcpWriter<'d> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.io.write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.io.flush().await } } @@ -612,7 +612,7 @@ pub mod client { async fn connect<'a>( &'a self, remote: embedded_nal_async::SocketAddr, - ) -> Result, Self::Error> + ) -> Result, Error> where Self: 'a, { @@ -673,7 +673,7 @@ pub mod client { impl<'d, const N: usize, const TX_SZ: usize, const RX_SZ: usize> embedded_io_async::Read for TcpConnection<'d, N, TX_SZ, RX_SZ> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { self.socket.read(buf).await } } @@ -681,11 +681,11 @@ pub mod client { impl<'d, const N: usize, const TX_SZ: usize, const RX_SZ: usize> embedded_io_async::Write for TcpConnection<'d, N, TX_SZ, RX_SZ> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.socket.write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.socket.flush().await } } diff --git a/embassy-nrf/src/buffered_uarte.rs b/embassy-nrf/src/buffered_uarte.rs index 10b8b0fbee..24dffe7d0b 100644 --- a/embassy-nrf/src/buffered_uarte.rs +++ b/embassy-nrf/src/buffered_uarte.rs @@ -591,19 +591,19 @@ mod _embedded_io { } impl<'d, U: UarteInstance, T: TimerInstance> embedded_io_async::Read for BufferedUarte<'d, U, T> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { self.inner_read(buf).await } } impl<'u, 'd: 'u, U: UarteInstance, T: TimerInstance> embedded_io_async::Read for BufferedUarteRx<'u, 'd, U, T> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { self.inner.inner_read(buf).await } } impl<'d, U: UarteInstance, T: TimerInstance> embedded_io_async::BufRead for BufferedUarte<'d, U, T> { - async fn fill_buf(&mut self) -> Result<&[u8], Self::Error> { + async fn fill_buf(&mut self) -> Result<&[u8], Error> { self.inner_fill_buf().await } @@ -613,7 +613,7 @@ mod _embedded_io { } impl<'u, 'd: 'u, U: UarteInstance, T: TimerInstance> embedded_io_async::BufRead for BufferedUarteRx<'u, 'd, U, T> { - async fn fill_buf(&mut self) -> Result<&[u8], Self::Error> { + async fn fill_buf(&mut self) -> Result<&[u8], Error> { self.inner.inner_fill_buf().await } @@ -623,21 +623,21 @@ mod _embedded_io { } impl<'d, U: UarteInstance, T: TimerInstance> embedded_io_async::Write for BufferedUarte<'d, U, T> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.inner_write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.inner_flush().await } } impl<'u, 'd: 'u, U: UarteInstance, T: TimerInstance> embedded_io_async::Write for BufferedUarteTx<'u, 'd, U, T> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.inner.inner_write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.inner.inner_flush().await } } diff --git a/embassy-nrf/src/gpiote.rs b/embassy-nrf/src/gpiote.rs index 7488bc085d..bde8240b50 100644 --- a/embassy-nrf/src/gpiote.rs +++ b/embassy-nrf/src/gpiote.rs @@ -515,45 +515,45 @@ mod eha { use super::*; impl<'d, T: GpioPin> embedded_hal_async::digital::Wait for Input<'d, T> { - async fn wait_for_high(&mut self) -> Result<(), Self::Error> { + async fn wait_for_high(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_high().await) } - async fn wait_for_low(&mut self) -> Result<(), Self::Error> { + async fn wait_for_low(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_low().await) } - async fn wait_for_rising_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_rising_edge(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_rising_edge().await) } - async fn wait_for_falling_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_falling_edge(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_falling_edge().await) } - async fn wait_for_any_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_any_edge(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_any_edge().await) } } impl<'d, T: GpioPin> embedded_hal_async::digital::Wait for Flex<'d, T> { - async fn wait_for_high(&mut self) -> Result<(), Self::Error> { + async fn wait_for_high(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_high().await) } - async fn wait_for_low(&mut self) -> Result<(), Self::Error> { + async fn wait_for_low(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_low().await) } - async fn wait_for_rising_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_rising_edge(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_rising_edge().await) } - async fn wait_for_falling_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_falling_edge(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_falling_edge().await) } - async fn wait_for_any_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_any_edge(&mut self) -> Result<(), Infallible> { Ok(self.wait_for_any_edge().await) } } diff --git a/embassy-nrf/src/lib.rs b/embassy-nrf/src/lib.rs index 355a00497b..13bc2fc7cb 100644 --- a/embassy-nrf/src/lib.rs +++ b/embassy-nrf/src/lib.rs @@ -1,5 +1,5 @@ #![no_std] -#![cfg_attr(feature = "nightly", feature(async_fn_in_trait, impl_trait_projections))] +#![cfg_attr(feature = "nightly", feature(async_fn_in_trait))] #![doc = include_str!("../README.md")] #![warn(missing_docs)] diff --git a/embassy-nrf/src/qspi.rs b/embassy-nrf/src/qspi.rs index 36ee33f6db..bf09aa3d8f 100644 --- a/embassy-nrf/src/qspi.rs +++ b/embassy-nrf/src/qspi.rs @@ -595,11 +595,11 @@ mod _eh1 { const WRITE_SIZE: usize = ::WRITE_SIZE; const ERASE_SIZE: usize = ::ERASE_SIZE; - async fn write(&mut self, offset: u32, data: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, offset: u32, data: &[u8]) -> Result<(), Error> { self.write(offset, data).await } - async fn erase(&mut self, from: u32, to: u32) -> Result<(), Self::Error> { + async fn erase(&mut self, from: u32, to: u32) -> Result<(), Error> { for address in (from..to).step_by(::ERASE_SIZE) { self.erase(address).await? } @@ -609,7 +609,7 @@ mod _eh1 { impl<'d, T: Instance> AsyncReadNorFlash for Qspi<'d, T> { const READ_SIZE: usize = 4; - async fn read(&mut self, address: u32, data: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, address: u32, data: &mut [u8]) -> Result<(), Error> { self.read(address, data).await } diff --git a/embassy-nrf/src/twim.rs b/embassy-nrf/src/twim.rs index fdea480e3b..b9e87d4f27 100644 --- a/embassy-nrf/src/twim.rs +++ b/embassy-nrf/src/twim.rs @@ -864,14 +864,14 @@ mod eh1 { mod eha { use super::*; impl<'d, T: Instance> embedded_hal_async::i2c::I2c for Twim<'d, T> { - async fn read(&mut self, address: u8, read: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, address: u8, read: &mut [u8]) -> Result<(), Error> { self.read(address, read).await } - async fn write(&mut self, address: u8, write: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, address: u8, write: &[u8]) -> Result<(), Error> { self.write(address, write).await } - async fn write_read(&mut self, address: u8, write: &[u8], read: &mut [u8]) -> Result<(), Self::Error> { + async fn write_read(&mut self, address: u8, write: &[u8], read: &mut [u8]) -> Result<(), Error> { self.write_read(address, write, read).await } @@ -879,7 +879,7 @@ mod eha { &mut self, address: u8, operations: &mut [embedded_hal_1::i2c::Operation<'_>], - ) -> Result<(), Self::Error> { + ) -> Result<(), Error> { let _ = address; let _ = operations; todo!() diff --git a/embassy-rp/src/flash.rs b/embassy-rp/src/flash.rs index 1c1c2449ec..4670aa7e45 100644 --- a/embassy-rp/src/flash.rs +++ b/embassy-rp/src/flash.rs @@ -390,7 +390,7 @@ impl<'d, T: Instance, const FLASH_SIZE: usize> embedded_storage_async::nor_flash { const READ_SIZE: usize = ASYNC_READ_SIZE; - async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Error> { self.read(offset, bytes).await } @@ -407,11 +407,11 @@ impl<'d, T: Instance, const FLASH_SIZE: usize> embedded_storage_async::nor_flash const ERASE_SIZE: usize = ERASE_SIZE; - async fn erase(&mut self, from: u32, to: u32) -> Result<(), Self::Error> { + async fn erase(&mut self, from: u32, to: u32) -> Result<(), Error> { self.blocking_erase(from, to) } - async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Error> { self.blocking_write(offset, bytes) } } diff --git a/embassy-rp/src/gpio.rs b/embassy-rp/src/gpio.rs index ad9d4262db..328aebc8db 100644 --- a/embassy-rp/src/gpio.rs +++ b/embassy-rp/src/gpio.rs @@ -1138,27 +1138,27 @@ mod eh1 { #[cfg(feature = "nightly")] impl<'d, T: Pin> embedded_hal_async::digital::Wait for Flex<'d, T> { - async fn wait_for_high(&mut self) -> Result<(), Self::Error> { + async fn wait_for_high(&mut self) -> Result<(), Infallible> { self.wait_for_high().await; Ok(()) } - async fn wait_for_low(&mut self) -> Result<(), Self::Error> { + async fn wait_for_low(&mut self) -> Result<(), Infallible> { self.wait_for_low().await; Ok(()) } - async fn wait_for_rising_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_rising_edge(&mut self) -> Result<(), Infallible> { self.wait_for_rising_edge().await; Ok(()) } - async fn wait_for_falling_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_falling_edge(&mut self) -> Result<(), Infallible> { self.wait_for_falling_edge().await; Ok(()) } - async fn wait_for_any_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_any_edge(&mut self) -> Result<(), Infallible> { self.wait_for_any_edge().await; Ok(()) } @@ -1166,27 +1166,27 @@ mod eh1 { #[cfg(feature = "nightly")] impl<'d, T: Pin> embedded_hal_async::digital::Wait for Input<'d, T> { - async fn wait_for_high(&mut self) -> Result<(), Self::Error> { + async fn wait_for_high(&mut self) -> Result<(), Infallible> { self.wait_for_high().await; Ok(()) } - async fn wait_for_low(&mut self) -> Result<(), Self::Error> { + async fn wait_for_low(&mut self) -> Result<(), Infallible> { self.wait_for_low().await; Ok(()) } - async fn wait_for_rising_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_rising_edge(&mut self) -> Result<(), Infallible> { self.wait_for_rising_edge().await; Ok(()) } - async fn wait_for_falling_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_falling_edge(&mut self) -> Result<(), Infallible> { self.wait_for_falling_edge().await; Ok(()) } - async fn wait_for_any_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_any_edge(&mut self) -> Result<(), Infallible> { self.wait_for_any_edge().await; Ok(()) } @@ -1194,27 +1194,27 @@ mod eh1 { #[cfg(feature = "nightly")] impl<'d, T: Pin> embedded_hal_async::digital::Wait for OutputOpenDrain<'d, T> { - async fn wait_for_high(&mut self) -> Result<(), Self::Error> { + async fn wait_for_high(&mut self) -> Result<(), Infallible> { self.wait_for_high().await; Ok(()) } - async fn wait_for_low(&mut self) -> Result<(), Self::Error> { + async fn wait_for_low(&mut self) -> Result<(), Infallible> { self.wait_for_low().await; Ok(()) } - async fn wait_for_rising_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_rising_edge(&mut self) -> Result<(), Infallible> { self.wait_for_rising_edge().await; Ok(()) } - async fn wait_for_falling_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_falling_edge(&mut self) -> Result<(), Infallible> { self.wait_for_falling_edge().await; Ok(()) } - async fn wait_for_any_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_any_edge(&mut self) -> Result<(), Infallible> { self.wait_for_any_edge().await; Ok(()) } diff --git a/embassy-rp/src/i2c.rs b/embassy-rp/src/i2c.rs index 7a5ddd325a..5b869f1d24 100644 --- a/embassy-rp/src/i2c.rs +++ b/embassy-rp/src/i2c.rs @@ -691,21 +691,21 @@ mod nightly { A: AddressMode + Into + 'static, T: Instance + 'd, { - async fn read(&mut self, address: A, read: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, address: A, read: &mut [u8]) -> Result<(), Error> { let addr: u16 = address.into(); Self::setup(addr)?; self.read_async_internal(read, false, true).await } - async fn write(&mut self, address: A, write: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, address: A, write: &[u8]) -> Result<(), Error> { let addr: u16 = address.into(); Self::setup(addr)?; self.write_async_internal(write.iter().copied(), true).await } - async fn write_read(&mut self, address: A, write: &[u8], read: &mut [u8]) -> Result<(), Self::Error> { + async fn write_read(&mut self, address: A, write: &[u8], read: &mut [u8]) -> Result<(), Error> { let addr: u16 = address.into(); Self::setup(addr)?; @@ -713,7 +713,7 @@ mod nightly { self.read_async_internal(read, false, true).await } - async fn transaction(&mut self, address: A, operations: &mut [Operation<'_>]) -> Result<(), Self::Error> { + async fn transaction(&mut self, address: A, operations: &mut [Operation<'_>]) -> Result<(), Error> { let addr: u16 = address.into(); if operations.len() > 0 { diff --git a/embassy-rp/src/lib.rs b/embassy-rp/src/lib.rs index 49bd3533e2..f1302b063c 100644 --- a/embassy-rp/src/lib.rs +++ b/embassy-rp/src/lib.rs @@ -1,5 +1,5 @@ #![no_std] -#![cfg_attr(feature = "nightly", feature(async_fn_in_trait, impl_trait_projections))] +#![cfg_attr(feature = "nightly", feature(async_fn_in_trait))] // This mod MUST go first, so that the others see its macros. pub(crate) mod fmt; diff --git a/embassy-rp/src/spi.rs b/embassy-rp/src/spi.rs index 46c440b84a..d3e797992b 100644 --- a/embassy-rp/src/spi.rs +++ b/embassy-rp/src/spi.rs @@ -573,23 +573,23 @@ mod eha { use super::*; impl<'d, T: Instance> embedded_hal_async::spi::SpiBus for Spi<'d, T, Async> { - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { Ok(()) } - async fn write(&mut self, words: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, words: &[u8]) -> Result<(), Error> { self.write(words).await } - async fn read(&mut self, words: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, words: &mut [u8]) -> Result<(), Error> { self.read(words).await } - async fn transfer(&mut self, read: &mut [u8], write: &[u8]) -> Result<(), Self::Error> { + async fn transfer(&mut self, read: &mut [u8], write: &[u8]) -> Result<(), Error> { self.transfer(read, write).await } - async fn transfer_in_place(&mut self, words: &mut [u8]) -> Result<(), Self::Error> { + async fn transfer_in_place(&mut self, words: &mut [u8]) -> Result<(), Error> { self.transfer_in_place(words).await } } diff --git a/embassy-rp/src/uart/buffered.rs b/embassy-rp/src/uart/buffered.rs index e57b725990..d18422a9bf 100644 --- a/embassy-rp/src/uart/buffered.rs +++ b/embassy-rp/src/uart/buffered.rs @@ -587,19 +587,19 @@ impl<'d, T: Instance> embedded_io_async::ErrorType for BufferedUartTx<'d, T> { } impl<'d, T: Instance + 'd> embedded_io_async::Read for BufferedUart<'d, T> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { BufferedUartRx::<'d, T>::read(buf).await } } impl<'d, T: Instance + 'd> embedded_io_async::Read for BufferedUartRx<'d, T> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { Self::read(buf).await } } impl<'d, T: Instance + 'd> embedded_io_async::BufRead for BufferedUart<'d, T> { - async fn fill_buf(&mut self) -> Result<&[u8], Self::Error> { + async fn fill_buf(&mut self) -> Result<&[u8], Error> { BufferedUartRx::<'d, T>::fill_buf().await } @@ -609,7 +609,7 @@ impl<'d, T: Instance + 'd> embedded_io_async::BufRead for BufferedUart<'d, T> { } impl<'d, T: Instance + 'd> embedded_io_async::BufRead for BufferedUartRx<'d, T> { - async fn fill_buf(&mut self) -> Result<&[u8], Self::Error> { + async fn fill_buf(&mut self) -> Result<&[u8], Error> { Self::fill_buf().await } @@ -619,21 +619,21 @@ impl<'d, T: Instance + 'd> embedded_io_async::BufRead for BufferedUartRx<'d, T> } impl<'d, T: Instance + 'd> embedded_io_async::Write for BufferedUart<'d, T> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { BufferedUartTx::<'d, T>::write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { BufferedUartTx::<'d, T>::flush().await } } impl<'d, T: Instance + 'd> embedded_io_async::Write for BufferedUartTx<'d, T> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { Self::write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { Self::flush().await } } diff --git a/embassy-stm32/src/exti.rs b/embassy-stm32/src/exti.rs index 925cf39be9..d29fa7d56c 100644 --- a/embassy-stm32/src/exti.rs +++ b/embassy-stm32/src/exti.rs @@ -167,31 +167,32 @@ mod eh1 { } #[cfg(all(feature = "unstable-traits", feature = "nightly"))] mod eha { + use core::convert::Infallible; use super::*; impl<'d, T: GpioPin> embedded_hal_async::digital::Wait for ExtiInput<'d, T> { - async fn wait_for_high(&mut self) -> Result<(), Self::Error> { + async fn wait_for_high(&mut self) -> Result<(), Infallible> { self.wait_for_high().await; Ok(()) } - async fn wait_for_low(&mut self) -> Result<(), Self::Error> { + async fn wait_for_low(&mut self) -> Result<(), Infallible> { self.wait_for_low().await; Ok(()) } - async fn wait_for_rising_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_rising_edge(&mut self) -> Result<(), Infallible> { self.wait_for_rising_edge().await; Ok(()) } - async fn wait_for_falling_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_falling_edge(&mut self) -> Result<(), Infallible> { self.wait_for_falling_edge().await; Ok(()) } - async fn wait_for_any_edge(&mut self) -> Result<(), Self::Error> { + async fn wait_for_any_edge(&mut self) -> Result<(), Infallible> { self.wait_for_any_edge().await; Ok(()) } diff --git a/embassy-stm32/src/flash/asynch.rs b/embassy-stm32/src/flash/asynch.rs index e966e2a77e..cee3594a70 100644 --- a/embassy-stm32/src/flash/asynch.rs +++ b/embassy-stm32/src/flash/asynch.rs @@ -59,7 +59,7 @@ impl interrupt::typelevel::Handler for Inter impl embedded_storage_async::nor_flash::ReadNorFlash for Flash<'_, Async> { const READ_SIZE: usize = super::READ_SIZE; - async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Error> { self.read(offset, bytes) } @@ -73,11 +73,11 @@ impl embedded_storage_async::nor_flash::NorFlash for Flash<'_, Async> { const WRITE_SIZE: usize = WRITE_SIZE; const ERASE_SIZE: usize = super::MAX_ERASE_SIZE; - async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Error> { self.write(offset, bytes).await } - async fn erase(&mut self, from: u32, to: u32) -> Result<(), Self::Error> { + async fn erase(&mut self, from: u32, to: u32) -> Result<(), Error> { self.erase(from, to).await } } @@ -162,7 +162,7 @@ foreach_flash_region! { impl embedded_storage_async::nor_flash::ReadNorFlash for crate::_generated::flash_regions::$type_name<'_, Async> { const READ_SIZE: usize = super::READ_SIZE; - async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Error> { self.read(offset, bytes).await } @@ -176,11 +176,11 @@ foreach_flash_region! { const WRITE_SIZE: usize = $write_size; const ERASE_SIZE: usize = $erase_size; - async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Error> { self.write(offset, bytes).await } - async fn erase(&mut self, from: u32, to: u32) -> Result<(), Self::Error> { + async fn erase(&mut self, from: u32, to: u32) -> Result<(), Error> { self.erase(from, to).await } } diff --git a/embassy-stm32/src/flash/f4.rs b/embassy-stm32/src/flash/f4.rs index 913950fe5b..31540cba78 100644 --- a/embassy-stm32/src/flash/f4.rs +++ b/embassy-stm32/src/flash/f4.rs @@ -146,7 +146,7 @@ mod alt_regions { impl embedded_storage_async::nor_flash::ReadNorFlash for $type_name<'_, Async> { const READ_SIZE: usize = crate::flash::READ_SIZE; - async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, offset: u32, bytes: &mut [u8]) -> Result<(), Error> { self.read(offset, bytes).await } @@ -160,11 +160,11 @@ mod alt_regions { const WRITE_SIZE: usize = $region.write_size as usize; const ERASE_SIZE: usize = $region.erase_size as usize; - async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, offset: u32, bytes: &[u8]) -> Result<(), Error> { self.write(offset, bytes).await } - async fn erase(&mut self, from: u32, to: u32) -> Result<(), Self::Error> { + async fn erase(&mut self, from: u32, to: u32) -> Result<(), Error> { self.erase(from, to).await } } diff --git a/embassy-stm32/src/i2c/v2.rs b/embassy-stm32/src/i2c/v2.rs index 36f70e32ec..a0f0994dcc 100644 --- a/embassy-stm32/src/i2c/v2.rs +++ b/embassy-stm32/src/i2c/v2.rs @@ -1049,15 +1049,15 @@ mod eha { use super::*; impl<'d, T: Instance, TXDMA: TxDma, RXDMA: RxDma> embedded_hal_async::i2c::I2c for I2c<'d, T, TXDMA, RXDMA> { - async fn read(&mut self, address: u8, read: &mut [u8]) -> Result<(), Self::Error> { + async fn read(&mut self, address: u8, read: &mut [u8]) -> Result<(), Error> { self.read(address, read).await } - async fn write(&mut self, address: u8, write: &[u8]) -> Result<(), Self::Error> { + async fn write(&mut self, address: u8, write: &[u8]) -> Result<(), Error> { self.write(address, write).await } - async fn write_read(&mut self, address: u8, write: &[u8], read: &mut [u8]) -> Result<(), Self::Error> { + async fn write_read(&mut self, address: u8, write: &[u8], read: &mut [u8]) -> Result<(), Error> { self.write_read(address, write, read).await } @@ -1065,7 +1065,7 @@ mod eha { &mut self, address: u8, operations: &mut [embedded_hal_1::i2c::Operation<'_>], - ) -> Result<(), Self::Error> { + ) -> Result<(), Error> { let _ = address; let _ = operations; todo!() diff --git a/embassy-stm32/src/sdmmc/mod.rs b/embassy-stm32/src/sdmmc/mod.rs index 6b532363ca..8191134ead 100644 --- a/embassy-stm32/src/sdmmc/mod.rs +++ b/embassy-stm32/src/sdmmc/mod.rs @@ -1491,12 +1491,7 @@ mod sdmmc_rs { impl<'d, T: Instance, Dma: SdmmcDma> BlockDevice for Sdmmc<'d, T, Dma> { type Error = Error; - async fn read( - &mut self, - blocks: &mut [Block], - start_block_idx: BlockIdx, - _reason: &str, - ) -> Result<(), Self::Error> { + async fn read(&mut self, blocks: &mut [Block], start_block_idx: BlockIdx, _reason: &str) -> Result<(), Error> { let mut address = start_block_idx.0; for block in blocks.iter_mut() { @@ -1510,7 +1505,7 @@ mod sdmmc_rs { Ok(()) } - async fn write(&mut self, blocks: &[Block], start_block_idx: BlockIdx) -> Result<(), Self::Error> { + async fn write(&mut self, blocks: &[Block], start_block_idx: BlockIdx) -> Result<(), Error> { let mut address = start_block_idx.0; for block in blocks.iter() { diff --git a/embassy-stm32/src/spi/mod.rs b/embassy-stm32/src/spi/mod.rs index 853de98f93..6d15378b4d 100644 --- a/embassy-stm32/src/spi/mod.rs +++ b/embassy-stm32/src/spi/mod.rs @@ -925,23 +925,23 @@ mod eha { use super::*; impl<'d, T: Instance, Tx: TxDma, Rx: RxDma, W: Word> embedded_hal_async::spi::SpiBus for Spi<'d, T, Tx, Rx> { - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { Ok(()) } - async fn write(&mut self, words: &[W]) -> Result<(), Self::Error> { + async fn write(&mut self, words: &[W]) -> Result<(), Error> { self.write(words).await } - async fn read(&mut self, words: &mut [W]) -> Result<(), Self::Error> { + async fn read(&mut self, words: &mut [W]) -> Result<(), Error> { self.read(words).await } - async fn transfer(&mut self, read: &mut [W], write: &[W]) -> Result<(), Self::Error> { + async fn transfer(&mut self, read: &mut [W], write: &[W]) -> Result<(), Error> { self.transfer(read, write).await } - async fn transfer_in_place(&mut self, words: &mut [W]) -> Result<(), Self::Error> { + async fn transfer_in_place(&mut self, words: &mut [W]) -> Result<(), Error> { self.transfer_in_place(words).await } } diff --git a/embassy-stm32/src/usart/buffered.rs b/embassy-stm32/src/usart/buffered.rs index 989c882059..ddaab51721 100644 --- a/embassy-stm32/src/usart/buffered.rs +++ b/embassy-stm32/src/usart/buffered.rs @@ -429,19 +429,19 @@ impl<'d, T: BasicInstance> embedded_io_async::ErrorType for BufferedUartTx<'d, T } impl<'d, T: BasicInstance> embedded_io_async::Read for BufferedUart<'d, T> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { self.rx.read(buf).await } } impl<'d, T: BasicInstance> embedded_io_async::Read for BufferedUartRx<'d, T> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { Self::read(self, buf).await } } impl<'d, T: BasicInstance> embedded_io_async::BufRead for BufferedUart<'d, T> { - async fn fill_buf(&mut self) -> Result<&[u8], Self::Error> { + async fn fill_buf(&mut self) -> Result<&[u8], Error> { self.rx.fill_buf().await } @@ -451,7 +451,7 @@ impl<'d, T: BasicInstance> embedded_io_async::BufRead for BufferedUart<'d, T> { } impl<'d, T: BasicInstance> embedded_io_async::BufRead for BufferedUartRx<'d, T> { - async fn fill_buf(&mut self) -> Result<&[u8], Self::Error> { + async fn fill_buf(&mut self) -> Result<&[u8], Error> { Self::fill_buf(self).await } @@ -461,21 +461,21 @@ impl<'d, T: BasicInstance> embedded_io_async::BufRead for BufferedUartRx<'d, T> } impl<'d, T: BasicInstance> embedded_io_async::Write for BufferedUart<'d, T> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.tx.write(buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.tx.flush().await } } impl<'d, T: BasicInstance> embedded_io_async::Write for BufferedUartTx<'d, T> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { Self::write(self, buf).await } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { Self::flush(self).await } } diff --git a/embassy-stm32/src/usart/mod.rs b/embassy-stm32/src/usart/mod.rs index bfb0567183..96f57ba71a 100644 --- a/embassy-stm32/src/usart/mod.rs +++ b/embassy-stm32/src/usart/mod.rs @@ -1048,12 +1048,12 @@ mod eio { T: BasicInstance, TxDma: super::TxDma, { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.write(buf).await?; Ok(buf.len()) } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.blocking_flush() } } @@ -1070,12 +1070,12 @@ mod eio { T: BasicInstance, TxDma: super::TxDma, { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { self.write(buf).await?; Ok(buf.len()) } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Error> { self.blocking_flush() } } diff --git a/embassy-stm32/src/usart/ringbuffered.rs b/embassy-stm32/src/usart/ringbuffered.rs index e990eaca86..102d8fbb32 100644 --- a/embassy-stm32/src/usart/ringbuffered.rs +++ b/embassy-stm32/src/usart/ringbuffered.rs @@ -245,7 +245,7 @@ mod eio { T: BasicInstance, Rx: RxDma, { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { self.read(buf).await } } diff --git a/embassy-sync/src/lib.rs b/embassy-sync/src/lib.rs index 8a9f841ee2..aca6ff38fc 100644 --- a/embassy-sync/src/lib.rs +++ b/embassy-sync/src/lib.rs @@ -1,5 +1,5 @@ #![cfg_attr(not(any(feature = "std", feature = "wasm")), no_std)] -#![cfg_attr(feature = "nightly", feature(async_fn_in_trait, impl_trait_projections))] +#![cfg_attr(feature = "nightly", feature(async_fn_in_trait))] #![allow(clippy::new_without_default)] #![doc = include_str!("../README.md")] #![warn(missing_docs)] diff --git a/embassy-sync/src/pipe.rs b/embassy-sync/src/pipe.rs index ec0cbbf2ac..b50866fa74 100644 --- a/embassy-sync/src/pipe.rs +++ b/embassy-sync/src/pipe.rs @@ -488,17 +488,17 @@ mod io_impls { } impl embedded_io_async::Read for &Pipe { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { Ok(Pipe::read(self, buf).await) } } impl embedded_io_async::Write for &Pipe { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { Ok(Pipe::write(self, buf).await) } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Infallible> { Ok(()) } } @@ -508,13 +508,13 @@ mod io_impls { } impl embedded_io_async::Read for Reader<'_, M, N> { - async fn read(&mut self, buf: &mut [u8]) -> Result { + async fn read(&mut self, buf: &mut [u8]) -> Result { Ok(Reader::read(self, buf).await) } } impl embedded_io_async::BufRead for Reader<'_, M, N> { - async fn fill_buf(&mut self) -> Result<&[u8], Self::Error> { + async fn fill_buf(&mut self) -> Result<&[u8], Infallible> { Ok(Reader::fill_buf(self).await) } @@ -528,11 +528,11 @@ mod io_impls { } impl embedded_io_async::Write for Writer<'_, M, N> { - async fn write(&mut self, buf: &[u8]) -> Result { + async fn write(&mut self, buf: &[u8]) -> Result { Ok(Writer::write(self, buf).await) } - async fn flush(&mut self) -> Result<(), Self::Error> { + async fn flush(&mut self) -> Result<(), Infallible> { Ok(()) } } diff --git a/examples/std/src/bin/net_ppp.rs b/examples/std/src/bin/net_ppp.rs index 9cf6e19dff..9ea07b29a0 100644 --- a/examples/std/src/bin/net_ppp.rs +++ b/examples/std/src/bin/net_ppp.rs @@ -8,7 +8,7 @@ //! nc 192.168.7.10 1234 #![feature(type_alias_impl_trait)] -#![feature(async_fn_in_trait, impl_trait_projections)] +#![feature(async_fn_in_trait)] #[path = "../serial_port.rs"] mod serial_port;