Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github CI yaml #934

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Update github CI yaml #934

merged 2 commits into from
Jun 28, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented Mar 22, 2023

This just takes some inspiration from the default output of a new Ember addon 👍

runs-on: ubuntu-latest
timeout-minutes: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect these timeouts won't work for the test suite

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this timeout is only for that particular test, and that test seems to be running in less than a minute so 10 mins is not so bad https://github.com/ember-cli/ember-try/actions/runs/4495038220/jobs/7908231867

The issue that we have is that any tests that hang will time out after 6 hours!! 😱 https://github.com/ember-cli/ember-try/actions/runs/4486271160/jobs/7888744453#step:6:1

I don't know who decided 6 hours was a reasonable default for a timeout but this PR now uses the "ember addon default" of 10 mins for normal tests and 20 mins for the longer smoke tests. And that will allow each test to run for 20 mins not a total running time for all scenarios 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last run of this is a great example of what I mean. Because I fixed CI in #933 all the dependabot PRs updated at the same time and drained the available workers for this repo to run CI. The elapsed time of the last run was quite high because it was waiting for workers but only each individual job was bound by its own timeout 👍

@mansona mansona force-pushed the update-github-ci branch 3 times, most recently from a8805ae to 144fde0 Compare March 22, 2023 23:04
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #934 (064b399) into master (4540780) will not change coverage.
The diff coverage is n/a.

❗ Current head 064b399 differs from pull request most recent head 845726b. Consider uploading reports for the commit 845726b to get more accurate results

@@           Coverage Diff           @@
##           master     #934   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          17       17           
  Lines         550      550           
=======================================
  Hits          519      519           
  Misses         31       31           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mansona mansona merged commit e060b86 into ember-cli:master Jun 28, 2023
@mansona mansona deleted the update-github-ci branch June 28, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants