Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not currently possible to debug in Node 8 #428

Closed
mansona opened this issue Jun 11, 2017 · 7 comments · Fixed by #505
Closed

Not currently possible to debug in Node 8 #428

mansona opened this issue Jun 11, 2017 · 7 comments · Fixed by #505

Comments

@mansona
Copy link
Member

mansona commented Jun 11, 2017

Because of the requirement to use node-inspector (and the incompatibility with --inspect) we have now been prevented from using Node 8 because node-inspector is incompatible with Node 8 node-inspector/node-inspector#1010

Now it makes us more dependent on the the issue linked in the readme

@kratiahuja
Copy link
Contributor

@mansona would it be possible for you to send a PR to update the readme?

@mansona
Copy link
Member Author

mansona commented Jun 17, 2017

Sure, I suppose 😂

I am just not too sure of a) what you want it to say and b) the merit of updating the readme to say "sorry no can do Node 8"

The reason it doesn't feel right to me is that Node 8.x is going to be LTS in a few months and my preference would just be for us to track the problem in an issue like this. If you still think I should try to summarise this in the Readme just say so and I'm happy to give it a whirl 👍

@kratiahuja
Copy link
Contributor

I think the limitation to use Node 8 is from debugging purposes. Therefore, it won't hurt to put an FYI so that users know about it and link the relevant inspector ticket.

@mansona
Copy link
Member Author

mansona commented Aug 16, 2017

Ok so it seems like there has been some movement on nodejs/node#7593 and testing this issue on node-nightly I was able to pause in the native node --inspect debugger:

➜ node-nightly --version
v9.0.0-nightly201708155f31d54720
➜ node-nightly --inspect node_modules/ember-cli/bin/ember s

Image of ember fastboot example paused in deugger

I know this isn't ideal for anyone who wants to use node --inspect natively but hopefully this is going to be merged into the v8.x branch 👍

@mansona
Copy link
Member Author

mansona commented Aug 16, 2017

Aha!! 🎉

It seems like this has already been merged and released into the v8.4 branch: nodejs/node#14811

I was able to successfully debug the fastboot execution with the following:

➜  github-fastboot-example git:(master) ✗ node -v
v8.4.0
➜  github-fastboot-example git:(master) ✗ node --inspect node_modules/ember-cli/bin/ember s

I guess all that is left is to update the documentation and say "if you want to inspect then use v8.4+"

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2017

Awesome news @mansona! We should definitely get the docs updated, this is so much easier now! 🎉

@mansona
Copy link
Member Author

mansona commented Aug 16, 2017

@rwjblue since it was so much easier I figured I'd spend a bit of time and update the docs 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants