-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not currently possible to debug in Node 8 #428
Comments
@mansona would it be possible for you to send a PR to update the readme? |
Sure, I suppose 😂 I am just not too sure of a) what you want it to say and b) the merit of updating the readme to say "sorry no can do Node 8" The reason it doesn't feel right to me is that Node 8.x is going to be LTS in a few months and my preference would just be for us to track the problem in an issue like this. If you still think I should try to summarise this in the Readme just say so and I'm happy to give it a whirl 👍 |
I think the limitation to use Node 8 is from debugging purposes. Therefore, it won't hurt to put an FYI so that users know about it and link the relevant inspector ticket. |
Ok so it seems like there has been some movement on nodejs/node#7593 and testing this issue on node-nightly I was able to pause in the native
I know this isn't ideal for anyone who wants to use |
Aha!! 🎉 It seems like this has already been merged and released into the v8.4 branch: nodejs/node#14811 I was able to successfully debug the fastboot execution with the following:
I guess all that is left is to update the documentation and say "if you want to inspect then use v8.4+" |
Awesome news @mansona! We should definitely get the docs updated, this is so much easier now! 🎉 |
@rwjblue since it was so much easier I figured I'd spend a bit of time and update the docs 😉 |
Because of the requirement to use node-inspector (and the incompatibility with --inspect) we have now been prevented from using Node 8 because node-inspector is incompatible with Node 8 node-inspector/node-inspector#1010
Now it makes us more dependent on the the issue linked in the readme
The text was updated successfully, but these errors were encountered: