-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components with with names of native elements throw compilation error #18530
Comments
Not sure what you mean here. Script and title both require closing tags (e.g. are not “self closing”).
Hmm, no I don’t think this is expected. Is it limited to title/script/noscript/style though? Does (for example) |
Not all of them. Im not sure about also you can use title as |
I suspect the issue is with the changes from tildeio/simple-html-tokenizer#69. Since (in the spec) element tag names are case insensitive, this patch does In addition, that PR lowercases the tag name and looks for a closing tag that is also lowercase (IOW it will match |
The fix is most likely to fix that PR over in simple-html-tokenizer to specifically only look for the lowercase variants (removing that |
@CvX - Do you think you might have any time to poke at this? To confirm my suspicion and/or send in a patch? |
@rwjblue I gave it at try here: tildeio/simple-html-tokenizer#81 |
Creating components with names of some native elements like
Script
,Title
etc results with an error :Unclosed element `Title` - glimmer-engine
when using them as a block:
Is it expected behavior?
Tested in Ember 3.13
The text was updated successfully, but these errors were encountered: