Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PromiseProxyMixin, PromiseArray, and PromiseObject #721

Closed
chriskrycho opened this issue Feb 11, 2021 · 2 comments
Closed

Deprecate PromiseProxyMixin, PromiseArray, and PromiseObject #721

chriskrycho opened this issue Feb 11, 2021 · 2 comments
Labels
T-ember-data RFCs that impact the ember-data library T-framework RFCs that impact the ember.js library

Comments

@chriskrycho
Copy link
Contributor

chriskrycho commented Feb 11, 2021

This is blocked on dropping 🔥 DIAF IE11 🔥 support with Ember 4, but once we do, we can begin the deprecation staging process for replacing PromiseProxyMixin, PromiseArray, and PromiseObject. This would have a couple nice knock-on effects:

  1. It would remove APIs long known to weird behavior: the way that PromiseProxyMixin and things derived from it try to make the Promise "invisible".
  2. It would remove one of the major blockers for removing Mixin in general, as these are some of the key (public API-visible) uses of Mixins in the framework.

Notably, each of these can be straightforwardly (though not necessarily transparently!) replaced by Octane idioms. The PromiseArray and PromiseObject types can likely be reimplemented in terms of native Proxy and also deprecated in favor of less confusing idioms, but doing it that way would allow us to drop PromiseProxyMixin first and then drop those two types later. That will also likely be necessary for making the transition work for Ember Data users.

@runspired
Copy link
Contributor

fwiw PromiseArray and PromiseObject do not come from ember but rather from ember-data and we already deprecated using them directly.

@runspired runspired added T-ember-data RFCs that impact the ember-data library T-framework RFCs that impact the ember.js library labels Apr 21, 2021
@runspired runspired moved this to RFC | Planning in EmberData Feb 18, 2022
@wagenet
Copy link
Member

wagenet commented Jul 23, 2022

See #832

@wagenet wagenet closed this as completed Jul 23, 2022
Repository owner moved this from RFC | Planning to RFC | Needs Implemented in EmberData Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-ember-data RFCs that impact the ember-data library T-framework RFCs that impact the ember.js library
Projects
Archived in project
Development

No branches or pull requests

3 participants