Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fswatch v1.13 ignores the --monitor parameter and always uses the default monitor #218

Closed
Vanav opened this issue Dec 4, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@Vanav
Copy link

Vanav commented Dec 4, 2018

Function below ignores type argument and always returns default monitor.

  monitor *monitor_factory::create_monitor(fsw_monitor_type type,
                                           std::vector<std::string> paths,
                                           FSW_EVENT_CALLBACK *callback,
                                           void *context)
  {
    switch (type)
    {
    case system_default_monitor_type:
      return create_default_monitor(paths, callback, context);

    default:
#if defined(HAVE_FSEVENTS_FILE_EVENTS)
      return new fsevents_monitor(paths, callback, context);
#elif defined(HAVE_SYS_EVENT_H)
      return new kqueue_monitor(paths, callback, context);
#elif defined(HAVE_PORT_H)
      return new fen_monitor(paths, callback, context);
#elif defined(HAVE_SYS_INOTIFY_H)
      return new inotify_monitor(paths, callback, context);
#elif defined(HAVE_WINDOWS)
      return new windows_monitor(paths, callback, context);
#else
      return new poll_monitor(paths, callback, context);
#endif
    }
}

monitor *monitor_factory::create_monitor(fsw_monitor_type type,

@Vanav Vanav changed the title fswatch v1.13 ignores --monitor parameter and always uses default monitor fswatch v1.13 ignores --monitor parameter and always uses default monitor Dec 4, 2018
@emcrisostomo
Copy link
Owner

Hi @Vanav, you're right. It's going to be fixed ASAP.

@emcrisostomo emcrisostomo self-assigned this Dec 4, 2018
@emcrisostomo emcrisostomo added this to the 1.14.0 milestone Dec 4, 2018
@emcrisostomo
Copy link
Owner

Fixed in 1.14.0

@emcrisostomo emcrisostomo changed the title fswatch v1.13 ignores --monitor parameter and always uses default monitor fswatch v1.13 ignores the --monitor parameter and always uses the default monitor Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants