Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the plugin as a babel macro. #132

Closed
tkh44 opened this issue Jul 11, 2017 · 1 comment · Fixed by #142
Closed

Implement the plugin as a babel macro. #132

tkh44 opened this issue Jul 11, 2017 · 1 comment · Fixed by #142
Assignees
@emmatown

Comments

@tkh44
Copy link
Member

tkh44 commented Jul 11, 2017 •
edited
Loading

We need this done in order to be ready for facebook/create-react-app#2730. For now, we could just do it alongside babel.js as macro.js. We can abstract most of babel.js easily (I think).

https://github.com/kentcdodds/babel-macros/blob/master/other/docs/author.md

https://github.com/kentcdodds/babel-macros/blob/master/src/__tests__/fixtures/emotion.macros.js

cc @kentcdodds @threepointone
@kentcdodds
Copy link
Contributor

This is what I did for preval, if that helps at all :)

@kentcdodds kentcdodds mentioned this issue Jul 12, 2017
Closed
@emmatown emmatown self-assigned this Jul 13, 2017
@emmatown emmatown mentioned this issue Jul 13, 2017
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmatown emmatown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the plugin as a babel macro
3 participants
@tkh44 @kentcdodds @emmatown