Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR?] change notes without firing a note on? #3

Closed
ajboni opened this issue Aug 8, 2024 · 4 comments
Closed

[FR?] change notes without firing a note on? #3

ajboni opened this issue Aug 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ajboni
Copy link
Contributor

ajboni commented Aug 8, 2024

Hello, first of all thanks for this AMAZING project!
was looking for something with "elektron-ish" and this its perfect!

My main issue is when trying to set up a sequence if I use the arrow key to change the note value, it will trigger a sound o each value.

I have some minor "first-user" feedback if you are interested as well.

@xaviergodart
Copy link
Member

Thanks for your feedback!

My reasoning for this was that I wanted to be able to "preview" the note while setting up a sequence. I personally need to hear the note to know if it's the correct one :)
Is this a problem for you when the sequencer is paused as well? or only when playing?

How would you imagine this to work? Adding a global option to disable the preview or something like that?

And of course, I'm always open for more feedback!

@xaviergodart xaviergodart added the enhancement New feature or request label Aug 8, 2024
@ajboni ajboni changed the title [FR?] change notes without firing a midi note? [FR?] change notes without firing a note on? Aug 8, 2024
@ajboni
Copy link
Contributor Author

ajboni commented Aug 8, 2024

Hmm, maybe an option/shortcut to disable the preview when playing would be great. I agree previewing the note is useful for certain cases (searching for a drum sound for example).

On the other hand, in my use case (live jamming) , It can 'ruin' the jam (imagine a chromatic instrument). I don' think it will be an issue while the sequencer is paused to be honest.

I will spend some days with it and I tried to leave constructive feedback, I think this can be a really nice companion for a small hardware setup

@xaviergodart
Copy link
Member

I just pushed a new version v0.1.2 that disable the note preview while playing. You're right, it makes no sense and it can ruin the performance. I kept the preview active when the sequencer is paused.

Does that work for you?

I will spend some days with it and I tried to leave constructive feedback, I think this can be a really nice companion for a small hardware setup

Thanks a lot 🙏

@ajboni
Copy link
Contributor Author

ajboni commented Aug 9, 2024

Does that work for you?

Works like a charm, thanks!!

@ajboni ajboni closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants