Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMULSIF-304: Banner component. #152

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

robherba
Copy link
Contributor

@robherba robherba commented Aug 26, 2024

Summary

Adds an banner component.

How to review this pull request

Screenshot 2024-11-11 at 2 30 23 AM Screenshot 2024-11-11 at 2 30 34 AM

@robherba robherba added the 👍 Ready for Review Work is ready for review. label Aug 26, 2024
@robherba robherba self-assigned this Aug 26, 2024
@callinmullaney callinmullaney added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Sep 10, 2024
Copy link
Contributor

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robherba This PR matches the design but I have some feedback for you:

  1. Lets try and avoid committing images (png, gif, jpg) directly to the repository and use a free service instead. https://picsum.photos/ is what we've used for Compound and seemed to work well. Here is an example of how we crafted a URL which defines the image size. I don't think you need to make this a responsive image so a standard <img src /> should be fine: https://github.com/emulsify-ds/compound/blob/main/components/02-molecules/text-with-media/text-with-media.yml#L4C16-L4C37

  2. See code comments on banner.twig

  3. Lets combine the bem() and add_attributes() functions. For example:

{% set banner__attributes = {
  'data-banner-alignment': banner__alignment|default('left'),
  'class': bem(banner__base_class, banner__modifiers, banner__blockname)
} %}

<div {{ add_attributes(banner__attributes) }}> ... </div>
  1. Avoid using CSS background images. Lets use the image component instead. Pull it it below all the banner content/text. Then use position:absolute, z-index, and object-fit styles. This makes wiring a lot easier and allows us to use responsive images.

src/components/banner/banner.twig Outdated Show resolved Hide resolved
src/components/banner/banner.twig Outdated Show resolved Hide resolved
src/components/banner/banner.twig Outdated Show resolved Hide resolved
@callinmullaney callinmullaney added 👉 Needs Work Reviewer has requested changes. and removed 👁 Review in progress Under review. labels Sep 10, 2024
Base automatically changed from convert-components-to-sdc to main October 23, 2024 16:35
@robherba robherba added 🚧 Work in Progress The PR is a work in progress. and removed 👉 Needs Work Reviewer has requested changes. labels Oct 24, 2024
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 5b339de
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/6731c1e30a038c0008c2109b
😎 Deploy Preview https://deploy-preview-152--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@robherba robherba added 👍 Ready for Review Work is ready for review. and removed 🚧 Work in Progress The PR is a work in progress. labels Nov 11, 2024
@robherba
Copy link
Contributor Author

Hey @callinmullaney, the changes have been applied!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for Review Work is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants