-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMULSIF-304: Banner component. #152
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robherba This PR matches the design but I have some feedback for you:
-
Lets try and avoid committing images (png, gif, jpg) directly to the repository and use a free service instead. https://picsum.photos/ is what we've used for Compound and seemed to work well. Here is an example of how we crafted a URL which defines the image size. I don't think you need to make this a responsive image so a standard
<img src />
should be fine: https://github.com/emulsify-ds/compound/blob/main/components/02-molecules/text-with-media/text-with-media.yml#L4C16-L4C37 -
See code comments on
banner.twig
-
Lets combine the
bem()
andadd_attributes()
functions. For example:
{% set banner__attributes = {
'data-banner-alignment': banner__alignment|default('left'),
'class': bem(banner__base_class, banner__modifiers, banner__blockname)
} %}
<div {{ add_attributes(banner__attributes) }}> ... </div>
- Avoid using CSS background images. Lets use the image component instead. Pull it it below all the banner content/text. Then use
position:absolute
,z-index
, andobject-fit
styles. This makes wiring a lot easier and allows us to use responsive images.
…ulsif-304--banner-component
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @callinmullaney, the changes have been applied! |
Summary
Adds an banner component.
How to review this pull request