This repository has been archived by the owner on Apr 15, 2022. It is now read-only.
Remove asm
feature
#44
Labels
Milestone
asm
feature
#44
asm
is getting stabilized upstream and the feature is not strictly necessary anymore for the implementation.Note that only the host side needs it, currently exclusively for the purpose of executing syscalls.
Unfortunately
miri
does not support inline assembly at the time of writing (rust-lang/miri#1045, rust-lang/miri#11 is the tracking issue)Few options here:
miri
andasm
feature - we lose potential for testing against UB on CImiri
for tests involving host side - greatly diminishes the benefit of actually usingmiri
miri
selectively for each test involving host side and inline assembly - this is going to be quite tedious to maintainmiri
. That may take long and that means we have to maintain the feature within the implementation, but that is actually fairly trivial, since the host simply ignores the syscalls when feature is disabled. Note, that it is possible that will have some mechanism in place for selectively disabling/enabling host-side call handlers at runtime in the future, if we had such functionality, we could then simply disable all calls requiringasm
whenmiri
is enabled and drop the feature.For now, I vote for 4. and suggest to revisit this in a few sprints.
Refs rust-lang/rust#91728 enarx/enarx#1178
The text was updated successfully, but these errors were encountered: