Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] rest_framework.filters.SearchFilter.filter_queryset fails with NoneType not iterable #3366

Closed
erj1 opened this issue Sep 3, 2015 · 5 comments

Comments

@erj1
Copy link

erj1 commented Sep 3, 2015

I updated my code base to use version 3.2.3 now my previously passing tests are now failing.

It seems to be related to Line: 105 in filters.py.

My view utilizes the module rest_framework.filters.SearchFilter; however the request that is failing is a PUT request without any search fields.

It seems that Commit b4b2dc removes the conditional preventing falsely search_fields from entering into the for loop.

Additional information can be provided upon request.

@jpadilla jpadilla added the Bug label Sep 3, 2015
@jpadilla
Copy link
Member

jpadilla commented Sep 3, 2015

@erj1 thanks for the report. At a glance it does seem like a valid issue. We should probably move L103-L106 after L109-L110.

@erj1
Copy link
Author

erj1 commented Sep 3, 2015

I looks like that has already been done in the non-released master branch. Closing ticket.

@jpadilla
Copy link
Member

jpadilla commented Sep 3, 2015

@erj1 perfect, thanks! It was fixed in #3324

@jpadilla jpadilla closed this as completed Sep 3, 2015
@jpadilla jpadilla removed the Bug label Sep 3, 2015
@erj1
Copy link
Author

erj1 commented Sep 3, 2015

I don't know your release cycle so excuse my ignorance. But when could I expect this update to be released?

@xordoquy
Copy link
Collaborator

xordoquy commented Sep 3, 2015

We'll likely make a release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants