Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank parameters are not passed into next field in results #4393

Closed
6 tasks done
MattHardcastle opened this issue Aug 12, 2016 · 1 comment
Closed
6 tasks done

Blank parameters are not passed into next field in results #4393

MattHardcastle opened this issue Aug 12, 2016 · 1 comment
Labels
Milestone

Comments

@MattHardcastle
Copy link

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

Visit a paginated API using blank URL parameter. For example: http://example.com/api/foo/?bar

Expected behavior

The next link in the results meta data should preserve the blank parameter. Example:

{
    "next": "http://example.com/api/foo/?bar&page=2",
   ...
}

Actual behavior

The next link in the results meta data swallows the blank parameter. Example:

{
    "next": "http://example.com/api/foo/?page=2",
   ...
}

I have an open pull request with a tests for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants