Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing comma in admin.html causes csrf error #4472

Closed
5 of 6 tasks
danielkeller opened this issue Sep 8, 2016 · 2 comments
Closed
5 of 6 tasks

Missing comma in admin.html causes csrf error #4472

danielkeller opened this issue Sep 8, 2016 · 2 comments
Labels
Milestone

Comments

@danielkeller
Copy link

danielkeller commented Sep 8, 2016

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

Load the admin

Expected behavior

No javascript errors happen

Actual behavior

Due to a missing comma here a javascript error occurs, causing requests made with the admin to fail with a CSRF error.

@xordoquy
Copy link
Collaborator

xordoquy commented Sep 8, 2016

Is this related to #4471 ?
How can we reproduce the admin issue ? As you might see with #4471, it seems to be working.

@tomchristie
Copy link
Member

Dammit, yup - needs resolving.
Same as #4435 but for the admin renderer.
Pull requests welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants