Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field_to_schema should handle ListField like ListSerializer #5311

Closed
5 of 6 tasks
tuky opened this issue Aug 7, 2017 · 1 comment
Closed
5 of 6 tasks

field_to_schema should handle ListField like ListSerializer #5311

tuky opened this issue Aug 7, 2017 · 1 comment

Comments

@tuky
Copy link
Contributor

tuky commented Aug 7, 2017

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

from rest_framework.serializers import *
from rest_framework.schemas import *
field_to_schema(ListField(child=CharField()))
field_to_schema(ListSerializer(child=CharField()))

Expected behavior

# output: <coreschema.schemas.Array object at 0x7fc81a0540d0>
# output: <coreschema.schemas.Array object at 0x7fc819b47cd0>

Actual behavior

# output: <coreschema.schemas.String object at 0x7fc81a0540d0>
# output: <coreschema.schemas.Array object at 0x7fc819b47cd0>

https://github.com/encode/django-rest-framework/blob/master/rest_framework/schemas.py#L33

@carltongibson
Copy link
Collaborator

Closed by #5326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants