Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compartment-mapper: add policy types #1776

Open
boneskull opened this issue Sep 18, 2023 · 1 comment
Open

compartment-mapper: add policy types #1776

boneskull opened this issue Sep 18, 2023 · 1 comment
Labels
enhancement New feature or request kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024 metamask

Comments

@boneskull
Copy link
Contributor

What is the Problem Being Solved?

Policies are essentially untyped (considered to be arbitrary objects). It would be helpful for consumers to have access to type information so that they do not construct invalid policies.

Description of the Design

A policy has a shape defined already; it's just a matter of formalizing that shape into types.

Security Considerations

none

Scaling Considerations

none

Test Plan

I'd probably want to add tsd tests for this; while it looks like tsd is used in other workspaces, I'll need to add the tsd package to compartment-mapper.

Upgrade Considerations

@boneskull boneskull added the enhancement New feature or request label Sep 18, 2023
@kriskowal kriskowal added kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024 metamask labels Jan 10, 2024
@dckc
Copy link
Contributor

dckc commented Jan 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024 metamask
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants