refactor(pass-style): Make @fast-check/ava a devDependency #2645
Conversation
|
Note to other reviewers: best to review diffs after hiding whitespace diffs |
|
Will the breaking change major version bump ripple thru the rest of endo packages? @kriskowal does this seem appropriate to you? We agonized about a similar situation not long ago. I don't recall clearly how similar. |
|
This technically means that the devDependency should become a peerDependency, the effect of which is that the package manager will not install a different version than the parent node_modules if there is a conflict, and won’t install it at all if the parent doesn’t need it, but will balk if the versions are incompatible. I can be assuaged about the compatibility break and even downgrade the |
Fixes #1741 Rather than importing `fc` directly to export arbitraries, @endo/pass-style/tools.js now returns them from an exported `makeArbitraries` function that requires `fc` as an argument. While technically a breaking change, it is pragmatically not marked as such because we are not aware of anything outside of Endo that imports a fast-check arbitrary.
gibson042
force-pushed
the
gibson-1741-fast-check-ava-dependency
branch
from
ef6e56a to
31864d4
Compare
gibson042
changed the title
|
Updated the commit and PR description to remove the breaking-change indication. |
There was a problem hiding this comment.
satisfied. thank you.
for the record, was green in CI with integration with agoric-sdk Agoric/agoric-sdk#10608
Fixes #1741
Caution
While technically a breaking change, it is pragmatically not marked as such because we are not aware of anything outside of Endo that imports a fast-check arbitrary.
Description
Rather than importing
fcdirectly to export arbitraries, @endo/pass-style/tools.js now returns them from an exportedmakeArbitrariesfunction that requiresfcas an argument.Best reviewed with whitespace ignored.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
n/a
Compatibility Considerations
This is a breaking change, but only to @endo/pass-style/tools.js. All imports in this repository have been updated, and I didn't see any in agoric-sdk or agoric-3-proposals, but if there are any then they will need similar updates.
Upgrade Considerations
This only affects code intended for testing, and I'm disinclined to even mention it in NEWS.md.