Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake in IpVersionsAndGrpcTypes/CredentialInjectorIntegrationTest.RetryOnClusterNotFound/0 #38263

Closed
alyssawilk opened this issue Jan 30, 2025 · 2 comments · Fixed by #38274
Closed

flake in IpVersionsAndGrpcTypes/CredentialInjectorIntegrationTest.RetryOnClusterNotFound/0 #38263

alyssawilk opened this issue Jan 30, 2025 · 2 comments · Fixed by #38274
Assignees
@vikaschoudhary16
Labels
area/test flakes

Comments

@alyssawilk
Copy link
Contributor

https://github.com/envoyproxy/envoy/actions/runs/13040014256/job/36379532254

@vikaschoudhary16 can you PTAL and see if you can reproduce? there's instructions on how to debug test flakes I think in test/integration - I can dig them up if you can't find them
@vikaschoudhary16
Copy link
Contributor

Sure. Will take a look

@vikaschoudhary16 vikaschoudhary16 mentioned this issue Jan 31, 2025
Merged
@vikaschoudhary16
Copy link
Contributor

#38274

wbpcode pushed a commit that referenced this issue Feb 5, 2025
@vikaschoudhary16
flake: fix credential_injector_oauth_integration_test/RetryOnClusterN…
c045a86 
…otFound (#38274)

Commit Message: test flake: fix
credential_injector_oauth_integration_test/RetryOnClusterNotFound
Additional Description: 
Test was verifying stat increment on every retry. Test was relying on
retry timeout to approximate the stat increment verification timeout.
This can fail based on resources/load on the underlying machine.
Now test has been changed from verifying stat increment on every failed
retry to if any retry happened which will be more stable.

fixes: #38263

Signed-off-by: Vikas Choudhary (vikasc) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikaschoudhary16 vikaschoudhary16

Labels
area/test flakes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

flake: fix credential_injector_oauth_integration_test/RetryOnClusterNotFound vikaschoudhary16/envoy
2 participants
@vikaschoudhary16 @alyssawilk