Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_restrict_string_escapes will break Envoy in Bazel 4.0 #9493

Closed
bazel-flag-bot opened this issue Dec 26, 2019 · 1 comment
Closed

Flag --incompatible_restrict_string_escapes will break Envoy in Bazel 4.0 #9493

bazel-flag-bot opened this issue Dec 26, 2019 · 1 comment
Assignees
@lizan
Labels
area/build no stalebot Disables stalebot from closing an issue

Comments

@bazel-flag-bot
Copy link

Incompatible flag --incompatible_restrict_string_escapes will be enabled by default in Bazel 3.0, thus breaking Envoy.

The flag is documented here: bazelbuild/bazel#8380

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.

If you don't want to receive any future issues for Envoy or if you have any questions,
please file an issue in https://github.com/bazelbuild/continuous-integration

Important: Please do NOT modify the issue title since that might break our tools.
@mattklein123 mattklein123 added area/build no stalebot Disables stalebot from closing an issue labels Dec 26, 2019
@mattklein123 mattklein123 added this to the 1.14.0 milestone Dec 29, 2019
@mattklein123 mattklein123 modified the milestones: 1.14.0, 1.15.0 Mar 18, 2020
@lizan lizan changed the title Flag --incompatible_restrict_string_escapes will break Envoy in Bazel 3.0 Flag --incompatible_restrict_string_escapes will break Envoy in Bazel 4.0 Apr 21, 2020
@mattklein123 mattklein123 removed this from the 1.15.0 milestone Jun 17, 2020
@lizan
Copy link
Member

lizan commented Jul 8, 2020

Fixed by #11520

@lizan lizan closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizan lizan

Labels
area/build no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lizan @mattklein123 @bazel-flag-bot